You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/01/04 21:41:54 UTC
[jira] Commented: (CASSANDRA-645) replace RowMutation w/ serialized
thrift structs
[ https://issues.apache.org/jira/browse/CASSANDRA-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796346#action_12796346 ]
Jonathan Ellis commented on CASSANDRA-645:
------------------------------------------
for future reference, this would have been far easier to review if it were structured something like
01: restructure StorageProxy mutate -> mutateLocal etc.
02: move helper methods out of RowMutation into MutationHelper
03: actually replace RowMutation w/ TableMutation et al
i.e., keep distinct refactors distinct.
(git can help with this: when you realize you need a new piece of the puzzle, you can commit your current work, then git co -b 645-2 and separate it out better there, with the safety net of being able to go back to your original branch and try again if it goes poorly.)
> replace RowMutation w/ serialized thrift structs
> ------------------------------------------------
>
> Key: CASSANDRA-645
> URL: https://issues.apache.org/jira/browse/CASSANDRA-645
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Gary Dusbabek
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 645-thrift.patch, 645-v1.patch
>
>
> using the client's representation internally will save basically a copy operation on the critical write path
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.