[GitHub] [beam] youngoli commented on a change in pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

[GitBox <gi...@apache.org>]

youngoli commented on a change in pull request #12758:
URL: https://github.com/apache/beam/pull/12758#discussion_r483258262



##########
File path: CHANGES.md
##########
@@ -100,6 +100,8 @@
 * Support for X source added (Java/Python) ([BEAM-X](https://issues.apache.org/jira/browse/BEAM-X)).
 * Add streaming support to SnowflakeIO in Java SDK ([BEAM-9896](https://issues.apache.org/jira/browse/BEAM-9896  ))
 * Support reading and writing to Google Healthcare DICOM APIs in Python SDK ([BEAM-10601](https://issues.apache.org/jira/browse/BEAM-10601))
+* Add dispositions for SnowflakeIO.write ([BEAM-10343](https://issues.apache.org/jira/browse/BEAM-10343))

Review comment:
       Hey Piotr. Option 1 is easily doable, but option 2 and 3 are not so much. Even though the changes are small and unlikely to break anything, adding them now would require building an entirely new RC. But moreso, the Beam release guide has some pretty strict expectations for a cherry-pick and I don't think this fits (https://beam.apache.org/contribute/release-guide/#review-cherry-picks). In particular, this doesn't seem to be a regression from a previous release, and it seems to be an update to a new feature, which can wait until 2.25. If there's an urgent reason to get it in ASAP that I'm missing, then let me know, but otherwise I think I'll limit the release changes to just fixing the changelog.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org