You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/20 03:26:08 UTC
[GitHub] [spark] LinhongLiu commented on issue #26177: [SPARK-29520][SS] Fix
checks of negative intervals
LinhongLiu commented on issue #26177: [SPARK-29520][SS] Fix checks of negative intervals
URL: https://github.com/apache/spark/pull/26177#issuecomment-544216888
I'm neutral on this PR.
But I have to remind that months, days and microseconds is designed to be 3 separated fields. It's simpler to just check `months >= 0 && days >= 0 && microseconds >= 0` and let user to choose their own combination to pass this constraint. If we make them convertible, things can be a bit more complex. I mean, you have to make some assumption to convert the fields and take care of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org