You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@apr.apache.org by bu...@apache.org on 2013/06/24 22:17:59 UTC

[Bug 55133] New: Several comment errors in the APR header files

https://issues.apache.org/bugzilla/show_bug.cgi?id=55133

            Bug ID: 55133
           Summary: Several comment errors in the APR header files
           Product: APR
           Version: HEAD
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: APR
          Assignee: bugs@apr.apache.org
          Reporter: mike.rumph@oracle.com

I have been trying to gain a more in depth knowledge of the Apache httpd and
APR source. In the process of studying through the APR headers, I noticed
several comment errors. So I will submit a patch containing 52 corrections
within a total of 14 of the APR header files.

These are a mix of comment typos and places where the comments and code do not
match.

I limited this patch to comment changes only.
In the case of the mismatches, it might be preferred to change the code in some
cases, such as the changes for apr_escape.h.

But I also noticed the following code blemishes:

The file apr_global_mutex.h includes apr_proc_mutex.h twice:

#include "apr.h"
#include "apr_proc_mutex.h"    /* only for apr_lockmech_e */
#include "apr_pools.h"
#include "apr_errno.h"
#if APR_PROC_MUTEX_IS_GLOBAL
#include "apr_proc_mutex.h"
#endif

And the file apr_thread_proc.h defines APR_NO_FILE twice.

I hope that this set of changes will help to improve the generated
documentation for APR and APR-util.

Thanks,

Mike

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 55133] Several comment errors in the APR header files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55133

--- Comment #4 from Mike Rumph <mi...@oracle.com> ---
Created attachment 30487
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30487&action=edit
Comment changes for apr-util-1.5.x header files

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 55133] Several comment errors in the APR header files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55133

--- Comment #3 from Mike Rumph <mi...@oracle.com> ---
Created attachment 30486
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30486&action=edit
Comment changes for apr-1.5.x header files

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 55133] Several comment errors in the APR header files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55133

Mike Rumph <mi...@oracle.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 55133] Several comment errors in the APR header files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55133

--- Comment #5 from Mike Rumph <mi...@oracle.com> ---
Created attachment 30488
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30488&action=edit
A slight correction to apr-util-1.5.x_comment changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 55133] Several comment errors in the APR header files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55133

--- Comment #1 from Mike Rumph <mi...@oracle.com> ---
Created attachment 30481
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30481&action=edit
A collection of comment corrections to the APR header files

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

[Bug 55133] Several comment errors in the APR header files

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55133

Jeff Trawick <tr...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Jeff Trawick <tr...@apache.org> ---
Committed to apr trunk as r1496407.
If you'll split this up by apr-1.5.x/apr-util-1.5.x I'll commit there as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org