You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by jr...@apache.org on 2023/04/10 16:56:25 UTC

[beam] branch release-2.47.0 updated: Disable JmsIOIT on amqp (#26200)

This is an automated email from the ASF dual-hosted git repository.

jrmccluskey pushed a commit to branch release-2.47.0
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/release-2.47.0 by this push:
     new d4662b9275f Disable JmsIOIT on amqp (#26200)
d4662b9275f is described below

commit d4662b9275fd45b6bac2946364440afed576424b
Author: Yi Hu <ya...@google.com>
AuthorDate: Mon Apr 10 12:56:14 2023 -0400

    Disable JmsIOIT on amqp (#26200)
---
 .../src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java  | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java b/sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java
index d7cd01f8158..fb6a08384f2 100644
--- a/sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java
+++ b/sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java
@@ -26,8 +26,8 @@ import static org.junit.Assert.assertTrue;
 import java.io.IOException;
 import java.io.Serializable;
 import java.time.Instant;
-import java.util.Arrays;
 import java.util.Collection;
+import java.util.Collections;
 import java.util.HashSet;
 import java.util.Set;
 import java.util.UUID;
@@ -132,13 +132,15 @@ public class JmsIOIT implements Serializable {
 
   @Parameterized.Parameters(name = "with client class {3}")
   public static Collection<Object[]> connectionFactories() {
-    return Arrays.asList(
+    return Collections.singletonList(
         new Object[] {
           "vm://localhost", 5672, "jms.sendAcksAsync=false", ActiveMQConnectionFactory.class
-        },
-        new Object[] {
-          "amqp://localhost", 5672, "jms.forceAsyncAcks=false", JmsConnectionFactory.class
         });
+    // TODO(https://github.com/apache/beam/issues/26175) Test failure on direct runner due to
+    //  JmsIO read on amqp slow on Jenkins.
+    // new Object[] {
+    //   "amqp://localhost", 5672, "jms.forceAsyncAcks=false", JmsConnectionFactory.class
+    // });
   }
 
   private final CommonJms commonJms;
@@ -164,6 +166,8 @@ public class JmsIOIT implements Serializable {
       this.commonJms.startBroker();
       connectionFactory = this.commonJms.getConnectionFactory();
       connectionFactoryClass = this.commonJms.getConnectionFactoryClass();
+      // use a small number of record for local integration test
+      OPTIONS.setNumberOfRecords(10000);
     }
   }