[GitHub] [ozone] sodonnel commented on a change in pull request #3078: HDDS-6308: EC: Handle Replication Factor to consider EC Config in Recon UI

[GitBox <gi...@apache.org>]

sodonnel commented on a change in pull request #3078:
URL: https://github.com/apache/ozone/pull/3078#discussion_r805994356



##########
File path: hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/client/TestReplicationConfig.java
##########
@@ -159,6 +160,35 @@ public void deserializeEC() {
     validate(config, EcCodec.valueOf(codec), data, parity, chunkSize);
   }
 
+  @Test
+  public void testECReplicationConfigGetReplication() {
+    assumeECType();
+    HddsProtos.ECReplicationConfig proto =
+        HddsProtos.ECReplicationConfig.newBuilder().setCodec(codec)
+            .setData(data).setParity(parity).setEcChunkSize(chunkSize).build();
+
+    ReplicationConfig config =
+        ReplicationConfig.fromProto(ReplicationType.EC, null, proto);
+
+    String ecReplicationParamsDelimiter = "-";

Review comment:
       Do you think it would make sense to make the static `EC_REPLICATION_PARAMS_DELIMITER` in `ECReplicationConfig` public and then reference it here? That way, if we ever changed the constant in `ECReplicationConfig`, it would mean the test doesn't need to be changed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org