You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/20 16:14:25 UTC
[GitHub] [kafka] xinzhuxiansheng opened a new pull request #8698: console-producer supports the setting of client.id
xinzhuxiansheng opened a new pull request #8698:
URL: https://github.com/apache/kafka/pull/8698
https://issues.apache.org/jira/browse/KAFKA-10022
"console-producer" supports the setting of "client.id", which is a reasonable requirement, and the way "console consumer" and "console producer" handle "client.id" can be unified. "client.id" defaults to "console-producer"
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-631738575
test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-631755813
There are known flaky tests that may fail, I'm validating that there's no consistent test failures. @xinzhuxiansheng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-631837548
test this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] xinzhuxiansheng commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id
Posted by GitBox <gi...@apache.org>.
xinzhuxiansheng commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-632888658
>
>
> @xinzhuxiansheng could you run the whole unit test suite locally since jenkins seems a bit unstable at the moment? You can run ` ./gradlew cleanTest test`
I executed './gradlew cleanTest test' , and there were many exceptions to the test Summary of gradle
Test Summary
5766 tests 9 failures 64 ignored
Failed tests:
SaslAuthenticatorFailureDelayTest. testClientConnectionClose[failedAuthenticationDelayMs=200]
SaslAuthenticatorFailureDelayTest. testInvalidPasswordSaslPlain[failedAuthenticationDelayMs=0]
SaslAuthenticatorFailureDelayTest. testInvalidPasswordSaslPlain[failedAuthenticationDelayMs=200]
SaslAuthenticatorTest. testAuthenticateCallbackHandlerMechanisms
SaslAuthenticatorTest. testCannotReauthenticateWithDifferentMechanism
SaslAuthenticatorTest. testMechanismPluggability
SaslAuthenticatorTest. testMultipleServerMechanisms
LoggingSignalHandlerTest. testRegister
UtilsTest. testFileAsStringNamedPipe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-633320764
I also ran the whole suite locally and only one flaky test in `SocketServerTest`. Will merge to trunk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang merged pull request #8698: KAFKA-10022:console-producer supports the setting of client.id
Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #8698:
URL: https://github.com/apache/kafka/pull/8698
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-632288255
test this jenkins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] xinzhuxiansheng edited a comment on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id
Posted by GitBox <gi...@apache.org>.
xinzhuxiansheng edited a comment on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-632888658
>
>
> @xinzhuxiansheng could you run the whole unit test suite locally since jenkins seems a bit unstable at the moment? You can run ` ./gradlew cleanTest test`
I executed './gradlew cleanTest test' , and there were many exceptions to the test Summary of gradle
Test Summary
5766 tests 9 failures 64 ignored
Failed tests:
SaslAuthenticatorFailureDelayTest. testClientConnectionClose[failedAuthenticationDelayMs=200]
SaslAuthenticatorFailureDelayTest. testInvalidPasswordSaslPlain[failedAuthenticationDelayMs=0]
SaslAuthenticatorFailureDelayTest. testInvalidPasswordSaslPlain[failedAuthenticationDelayMs=200]
SaslAuthenticatorTest. testAuthenticateCallbackHandlerMechanisms
SaslAuthenticatorTest. testCannotReauthenticateWithDifferentMechanism
SaslAuthenticatorTest. testMechanismPluggability
SaslAuthenticatorTest. testMultipleServerMechanisms
LoggingSignalHandlerTest. testRegister
UtilsTest. testFileAsStringNamedPipe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-631837772
test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] itantiger commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id
Posted by GitBox <gi...@apache.org>.
itantiger commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-633573331
We can add client.id through configuration file such as producer.config or consumer.config, What is the purpose of this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-631810146
test this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] xinzhuxiansheng commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id
Posted by GitBox <gi...@apache.org>.
xinzhuxiansheng commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-632275998
>
>
> test this please
I just added a unit test to validate the code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-632358479
@xinzhuxiansheng could you run the whole unit test suite locally since jenkins seems a bit unstable at the moment? You can run ` ./gradlew cleanTest test`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-632288176
`test this` is actually a keyword to trigger jenkins job :) But thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8698:
URL: https://github.com/apache/kafka/pull/8698#issuecomment-633667449
Before this patch, the client.id set in the config file would be overridden.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org