You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gearpump.apache.org by manuzhang <gi...@git.apache.org> on 2017/02/17 09:03:45 UTC
[GitHub] incubator-gearpump pull request #151: [GEARPUMP-274] Set lower bound of time...
GitHub user manuzhang opened a pull request:
https://github.com/apache/incubator-gearpump/pull/151
[GEARPUMP-274] Set lower bound of time to Long.MinValue milliseconds
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the commit message is formatted like:
`[GEARPUMP-<Jira issue #>] Meaningful description of pull request`
- [ ] Make sure tests pass via `sbt clean test`.
- [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manuzhang/incubator-gearpump time
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gearpump/pull/151.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #151
----
commit 73a08d537780d5f5dd050e813a178466e0469229
Author: manuzhang <ow...@gmail.com>
Date: 2017-02-17T08:58:33Z
[GEARPUMP-274] Set lower bound of time to Long.MinValue milliseconds
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #151: [GEARPUMP-274] Set lower bound of time to Lon...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/151
# [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/151?src=pr&el=h1) Report
> Merging [#151](https://codecov.io/gh/apache/incubator-gearpump/pull/151?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/df40cbdbd6e289f6a7ee8456e033ebc3db605b83?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `100%`.
```diff
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
+ Coverage 71.56% 71.63% +0.06%
==========================================
Files 191 191
Lines 6070 6070
Branches 510 510
==========================================
+ Hits 4344 4348 +4
+ Misses 1726 1722 -4
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/151?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/151?src=pr&el=footer). Last update [df40cbd...73a08d5](https://codecov.io/gh/apache/incubator-gearpump/compare/df40cbdbd6e289f6a7ee8456e033ebc3db605b83...73a08d537780d5f5dd050e813a178466e0469229?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #151: [GEARPUMP-274] Set lower bound of time to Lon...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/151
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump pull request #151: [GEARPUMP-274] Set lower bound of time...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-gearpump/pull/151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #151: [GEARPUMP-274] Set lower bound of time to Lon...
Posted by huafengw <gi...@git.apache.org>.
Github user huafengw commented on the issue:
https://github.com/apache/incubator-gearpump/pull/151
That's it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-gearpump issue #151: [GEARPUMP-274] Set lower bound of time to Lon...
Posted by manuzhang <gi...@git.apache.org>.
Github user manuzhang commented on the issue:
https://github.com/apache/incubator-gearpump/pull/151
@huafengw no, you are right. There are more changes required and I need to fix https://issues.apache.org/jira/browse/GEARPUMP-278 in following PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---