Re: [PR] fix(iceberg): preserve table-default properties for staged creates [polaris]

["dimas-b (via GitHub)" <gi...@apache.org>]

dimas-b commented on code in PR #4160:
URL: https://github.com/apache/polaris/pull/4160#discussion_r3210401347


##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -475,6 +478,11 @@ public LoadTableResponse createTableDirect(
 
     Map<String, String> properties = Maps.newHashMap();
     properties.put("created-at", OffsetDateTime.now(ZoneOffset.UTC).toString());
+    if (baseCatalog instanceof IcebergCatalog polarisCatalog) {
+      properties.putAll(
+          PropertyUtil.propertiesWithPrefix(
+              polarisCatalog.properties(), CatalogProperties.TABLE_DEFAULT_PREFIX));

Review Comment:
   I believe this kind of behaviour change deserves a discussed on the `dev` ML... Is there an existing thread for this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org