You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/06/05 01:35:28 UTC
Review Request 22252: Change MesosContainerizer::update to not return
failure for unknown container.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22252/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-1417
https://issues.apache.org/jira/browse/MESOS-1417
Repository: mesos-git
Description
-------
Change MesosContainerizer::update to not return failure for unknown container.
During status update for terminal task state change the slave will try to update the container's resources. However, in the meantime the executor may have exited and the container been destroyed.
Diffs
-----
src/slave/containerizer/mesos_containerizer.cpp 14380240512d29b49c2e8f2831a9ef8ca102a024
Diff: https://reviews.apache.org/r/22252/diff/
Testing
-------
make check
Thanks,
Ian Downes
Re: Review Request 22252: Change MesosContainerizer::update to not return
failure for unknown container.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22252/#review44777
-----------------------------------------------------------
Ship it!
src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/22252/#comment79317>
Can you update the comment with what you have in the description? :)
- Vinod Kone
On June 4, 2014, 11:36 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22252/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 11:36 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-1417
> https://issues.apache.org/jira/browse/MESOS-1417
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Change MesosContainerizer::update to not return failure for unknown container.
>
> During status update for terminal task state change the slave will try to update the container's resources. However, in the meantime the executor may have exited and the container been destroyed.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos_containerizer.cpp 14380240512d29b49c2e8f2831a9ef8ca102a024
>
> Diff: https://reviews.apache.org/r/22252/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 22252: Change MesosContainerizer::update to not return
failure for unknown container.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22252/#review44830
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On June 5, 2014, 12:16 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22252/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 12:16 a.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-1417
> https://issues.apache.org/jira/browse/MESOS-1417
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Change MesosContainerizer::update to not return failure for unknown container.
>
> During status update for terminal task state change the slave will try to update the container's resources. However, in the meantime the executor may have exited and the container been destroyed.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos_containerizer.cpp 14380240512d29b49c2e8f2831a9ef8ca102a024
>
> Diff: https://reviews.apache.org/r/22252/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 22252: Change MesosContainerizer::update to not return
failure for unknown container.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22252/
-----------------------------------------------------------
(Updated June 4, 2014, 5:16 p.m.)
Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
Changes
-------
Addressed Vinod's comments.
Bugs: MESOS-1417
https://issues.apache.org/jira/browse/MESOS-1417
Repository: mesos-git
Description
-------
Change MesosContainerizer::update to not return failure for unknown container.
During status update for terminal task state change the slave will try to update the container's resources. However, in the meantime the executor may have exited and the container been destroyed.
Diffs (updated)
-----
src/slave/containerizer/mesos_containerizer.cpp 14380240512d29b49c2e8f2831a9ef8ca102a024
Diff: https://reviews.apache.org/r/22252/diff/
Testing
-------
make check
Thanks,
Ian Downes
Re: Review Request 22252: Change MesosContainerizer::update to not return
failure for unknown container.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22252/
-----------------------------------------------------------
(Updated June 4, 2014, 4:36 p.m.)
Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
Changes
-------
Add Jie
Bugs: MESOS-1417
https://issues.apache.org/jira/browse/MESOS-1417
Repository: mesos-git
Description
-------
Change MesosContainerizer::update to not return failure for unknown container.
During status update for terminal task state change the slave will try to update the container's resources. However, in the meantime the executor may have exited and the container been destroyed.
Diffs
-----
src/slave/containerizer/mesos_containerizer.cpp 14380240512d29b49c2e8f2831a9ef8ca102a024
Diff: https://reviews.apache.org/r/22252/diff/
Testing
-------
make check
Thanks,
Ian Downes