You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by Karsten Bräckelmann <gu...@rudersport.de> on 2011/03/24 02:56:23 UTC

Re: [Bug 6558] [review] __PILL_PRICE rules (having "tflags multiple") cause infinite loop when compiled

On Thu, 2011-03-24 at 01:48 +0100, Mark Martinec wrote:
> > It'd be nice if I could see these warnings in the make+make test+masscheck
> > I (try to) do before commits...
> 
> I agree.
> 
> Currently what is necessary is to ditch a sa-compile.cache
> directory, e.g.
> 
>   rm -rf /root/.spamassassin/sa-compile.cache
> 
> before a sa-compile, otherwise results are fetched from
> previous runs and rules with their regexps are not
> re-assessed - no warnings would be issued for rules
> cached from previous runs.

Maybe it's just me being terribly confused, but... Something that
changed, never should be fetched from a cache.

If this is referring to a cache pre-change, that would be easy to
overcome.


-- 
char *t="\10pse\0r\0dtu\0.@ghno\x4e\xc8\x79\xf4\xab\x51\x8a\x10\xf4\xf4\xc4";
main(){ char h,m=h=*t++,*x=t+2*h,c,i,l=*x,s=0; for (i=0;i<l;i++){ i%8? c<<=1:
(c=*++x); c&128 && (s+=h); if (!(h>>=1)||!t[s+h]){ putchar(t[s]);h=m;s=0; }}}


Re: [Bug 6558] [review] __PILL_PRICE rules (having "tflags multiple") cause infinite loop when compiled

Posted by John Hardin <jh...@impsec.org>.
On Thu, 24 Mar 2011, Karsten Br�ckelmann wrote:

> On Thu, 2011-03-24 at 01:48 +0100, Mark Martinec wrote:
>>> It'd be nice if I could see these warnings in the make+make test+masscheck
>>> I (try to) do before commits...
>>
>> I agree.
>>
>> Currently what is necessary is to ditch a sa-compile.cache
>> directory, e.g.
>>
>>   rm -rf /root/.spamassassin/sa-compile.cache
>>
>> before a sa-compile, otherwise results are fetched from
>> previous runs and rules with their regexps are not
>> re-assessed - no warnings would be issued for rules
>> cached from previous runs.
>
> Maybe it's just me being terribly confused, but... Something that
> changed, never should be fetched from a cache.
>
> If this is referring to a cache pre-change, that would be easy to
> overcome.

Apply this patch and not change any rules, and the lint won't be run. The 
cache will be used until a rule changes.

-- 
  John Hardin KA7OHZ                    http://www.impsec.org/~jhardin/
  jhardin@impsec.org    FALaholic #11174     pgpk -a jhardin@impsec.org
  key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C  AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
   Gun Control laws aren't enacted to control guns, they are enacted
   to control people: catholics (1500s), japanese peasants (1600s),
   blacks (1860s), italian immigrants (1911), the irish (1920s),
   jews (1930s), blacks (1960s), the poor (always)
-----------------------------------------------------------------------
  6 days until the M1911 is 100 years old - and still going strong!