You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/02/13 04:28:16 UTC
Review Request 18056: Allow view deployment as a Web App
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18056/
-----------------------------------------------------------
Review request for Ambari, Artem Baranchuk and Nate Cole.
Bugs: AMBARI-4646
https://issues.apache.org/jira/browse/AMBARI-4646
Repository: ambari
Description
-------
Create a WebAppContext for each deployed view instance to allow for flexibilty in defining view UI.
* Remove servlet and servlet-mapping from the view.xml in favor of WEB-INF/web.xml.
* Instead of adding view servlets to the root servlet context, create a web app context for each view instance. This allows for filters, listeners, welcome file list, context root, etc to be defined for each view instance.
* Allow for static UI content in view archive and default context path for each view instance.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java faaf0ee
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 7efea04
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java 17d3b94
ambari-server/src/main/java/org/apache/ambari/server/view/ViewDefinition.java 4d813c6
ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceDefinition.java 7a7a5eb
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 8781d89
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ServletConfig.java a62d0f3
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ServletMappingConfig.java cc11e07
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java 90e4a24
ambari-server/src/test/java/org/apache/ambari/server/view/ViewDefinitionTest.java 92766df
ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceDefinitionTest.java 6df3e1e
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 20bae47
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ServletConfigTest.java 8cf0ff7
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ServletMappingConfigTest.java c0447bb
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java 04e71a8
ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java b81fb09
Diff: https://reviews.apache.org/r/18056/diff/
Testing
-------
Thanks,
Tom Beerbower
Re: Review Request 18056: Allow view deployment as a Web App
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18056/#review34490
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Feb. 12, 2014, 10:33 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18056/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2014, 10:33 p.m.)
>
>
> Review request for Ambari, Artem Baranchuk and Nate Cole.
>
>
> Bugs: AMBARI-4646
> https://issues.apache.org/jira/browse/AMBARI-4646
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a WebAppContext for each deployed view instance to allow for flexibilty in defining view UI.
>
> * Remove servlet and servlet-mapping from the view.xml in favor of WEB-INF/web.xml.
> * Instead of adding view servlets to the root servlet context, create a web app context for each view instance. This allows for filters, listeners, welcome file list, context root, etc to be defined for each view instance.
> * Allow for static UI content in view archive and default context path for each view instance.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java faaf0ee
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 7efea04
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java 17d3b94
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewDefinition.java 4d813c6
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceDefinition.java 7a7a5eb
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 8781d89
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ServletConfig.java a62d0f3
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ServletMappingConfig.java cc11e07
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java 90e4a24
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewDefinitionTest.java 92766df
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceDefinitionTest.java 6df3e1e
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 20bae47
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ServletConfigTest.java 8cf0ff7
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ServletMappingConfigTest.java c0447bb
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java 04e71a8
> ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java b81fb09
>
> Diff: https://reviews.apache.org/r/18056/diff/
>
>
> Testing
> -------
>
> Added new unit tests.
>
> All ambari-server unit tests pass :
>
> Results :
>
> Tests run: 1392, Failures: 0, Errors: 0, Skipped: 7
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 18056: Allow view deployment as a Web App
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18056/#review34511
-----------------------------------------------------------
Ship it!
Ship It!
- Artem Baranchuk
On Feb. 13, 2014, 3:33 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18056/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 3:33 a.m.)
>
>
> Review request for Ambari, Artem Baranchuk and Nate Cole.
>
>
> Bugs: AMBARI-4646
> https://issues.apache.org/jira/browse/AMBARI-4646
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create a WebAppContext for each deployed view instance to allow for flexibilty in defining view UI.
>
> * Remove servlet and servlet-mapping from the view.xml in favor of WEB-INF/web.xml.
> * Instead of adding view servlets to the root servlet context, create a web app context for each view instance. This allows for filters, listeners, welcome file list, context root, etc to be defined for each view instance.
> * Allow for static UI content in view archive and default context path for each view instance.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java faaf0ee
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 7efea04
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java 17d3b94
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewDefinition.java 4d813c6
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceDefinition.java 7a7a5eb
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 8781d89
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ServletConfig.java a62d0f3
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ServletMappingConfig.java cc11e07
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java 90e4a24
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewDefinitionTest.java 92766df
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceDefinitionTest.java 6df3e1e
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 20bae47
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ServletConfigTest.java 8cf0ff7
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ServletMappingConfigTest.java c0447bb
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java 04e71a8
> ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java b81fb09
>
> Diff: https://reviews.apache.org/r/18056/diff/
>
>
> Testing
> -------
>
> Added new unit tests.
>
> All ambari-server unit tests pass :
>
> Results :
>
> Tests run: 1392, Failures: 0, Errors: 0, Skipped: 7
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 18056: Allow view deployment as a Web App
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18056/
-----------------------------------------------------------
(Updated Feb. 13, 2014, 3:33 a.m.)
Review request for Ambari, Artem Baranchuk and Nate Cole.
Bugs: AMBARI-4646
https://issues.apache.org/jira/browse/AMBARI-4646
Repository: ambari
Description
-------
Create a WebAppContext for each deployed view instance to allow for flexibilty in defining view UI.
* Remove servlet and servlet-mapping from the view.xml in favor of WEB-INF/web.xml.
* Instead of adding view servlets to the root servlet context, create a web app context for each view instance. This allows for filters, listeners, welcome file list, context root, etc to be defined for each view instance.
* Allow for static UI content in view archive and default context path for each view instance.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java faaf0ee
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java 7efea04
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewResourceProvider.java 17d3b94
ambari-server/src/main/java/org/apache/ambari/server/view/ViewDefinition.java 4d813c6
ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceDefinition.java 7a7a5eb
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 8781d89
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ServletConfig.java a62d0f3
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ServletMappingConfig.java cc11e07
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java 90e4a24
ambari-server/src/test/java/org/apache/ambari/server/view/ViewDefinitionTest.java 92766df
ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceDefinitionTest.java 6df3e1e
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 20bae47
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ServletConfigTest.java 8cf0ff7
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ServletMappingConfigTest.java c0447bb
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java 04e71a8
ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java b81fb09
Diff: https://reviews.apache.org/r/18056/diff/
Testing (updated)
-------
Added new unit tests.
All ambari-server unit tests pass :
Results :
Tests run: 1392, Failures: 0, Errors: 0, Skipped: 7
Thanks,
Tom Beerbower