You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/04 10:04:33 UTC

[GitHub] [kafka] showuon opened a new pull request #8611: MINOR: Format the notation content for better readability

showuon opened a new pull request #8611:
URL: https://github.com/apache/kafka/pull/8611


   **before:**
   ![image](https://user-images.githubusercontent.com/43372967/80954688-745c4580-8e30-11ea-9330-fe7f6321adce.png)
   
   Here, the notation words are not in different format, makes it hard to read.  Especially the last example `/hello -> world`, it's hard to understand it if you don't read carefully.
   
   **after:**
   ![image](https://user-images.githubusercontent.com/43372967/80954777-9ce43f80-8e30-11ea-851f-ab45a4f8f133.png)
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #8611: MINOR: Format the notation content for better readability

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #8611:
URL: https://github.com/apache/kafka/pull/8611#issuecomment-623870362


   Hi @mjsax , would you please review this small PR? Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #8611: MINOR: Format the notation content for better readability

Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #8611:
URL: https://github.com/apache/kafka/pull/8611#issuecomment-624455001


   Hi @ijuma  , would you please review this small PR? Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax commented on pull request #8611: MINOR: Format the notation content for better readability

Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #8611:
URL: https://github.com/apache/kafka/pull/8611#issuecomment-626048519


   Thanks for the PR @showuon! Merged to `trunk`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org