[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #8448: [Fix-8213][Master] task run error when worker group name contains uppercase letters

[GitBox <gi...@apache.org>]

caishunfeng commented on a change in pull request #8448:
URL: https://github.com/apache/dolphinscheduler/pull/8448#discussion_r810485981



##########
File path: dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/registry/ServerNodeManager.java
##########
@@ -363,7 +363,6 @@ private void syncMasterNodes(Collection<String> nodes, List<Server> masterNodes)
     private void syncWorkerGroupNodes(String workerGroup, Collection<String> nodes) {
         workerGroupLock.lock();
         try {
-            workerGroup = workerGroup.toLowerCase();

Review comment:
       Will this affect the zk part of worker group?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org