You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/26 21:12:11 UTC

[GitHub] [airflow] mik-laj opened a new pull request #7894: Don't use DagBag in set_is_paused method

mik-laj opened a new pull request #7894: Don't use DagBag in set_is_paused method
URL: https://github.com/apache/airflow/pull/7894
 
 
   I decided to split PR to make it easier to fix errors.
   
   Part of https://github.com/apache/airflow/pull/7806
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #7894: Don't use DagBag in set_is_paused method

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7894: Don't use DagBag in set_is_paused method
URL: https://github.com/apache/airflow/pull/7894
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #7894: Don't use DagBag in set_is_paused method

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7894: Don't use DagBag in set_is_paused method
URL: https://github.com/apache/airflow/pull/7894#issuecomment-604728208
 
 
   @ashb @kaxil This is slightly related to DAG serialization. I am not sure if this is an identical behavior. Can I ask for a look?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7894: Don't use DagBag in set_is_paused method

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7894: Don't use DagBag in set_is_paused method
URL: https://github.com/apache/airflow/pull/7894#issuecomment-605433320
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7894?src=pr&el=h1) Report
   > Merging [#7894](https://codecov.io/gh/apache/airflow/pull/7894?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/3cb1e6c2d19b7c4233456d08d5d652ede2bae999&el=desc) will **increase** coverage by `0.24%`.
   > The diff coverage is `96.15%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7894/graphs/tree.svg?width=650&height=150&src=pr&token=WdLKlKHOAU)](https://codecov.io/gh/apache/airflow/pull/7894?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7894      +/-   ##
   ==========================================
   + Coverage   86.36%   86.60%   +0.24%     
   ==========================================
     Files         929      929              
     Lines       45036    45055      +19     
   ==========================================
   + Hits        38895    39022     +127     
   + Misses       6141     6033     -108     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7894?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7894/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==) | `56.87% <0.00%> (ø)` | |
   | [airflow/utils/log/logging\_mixin.py](https://codecov.io/gh/apache/airflow/pull/7894/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvbG9nZ2luZ19taXhpbi5weQ==) | `95.38% <ø> (ø)` | |
   | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7894/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.69% <ø> (ø)` | |
   | [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/7894/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7894/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <100.00%> (ø)` | |
   | [airflow/hooks/filesystem.py](https://codecov.io/gh/apache/airflow/pull/7894/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9maWxlc3lzdGVtLnB5) | `90.90% <100.00%> (ø)` | |
   | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7894/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `90.94% <100.00%> (ø)` | |
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7894/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `91.48% <100.00%> (+0.48%)` | :arrow_up: |
   | [airflow/models/dagbag.py](https://codecov.io/gh/apache/airflow/pull/7894/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnYmFnLnB5) | `89.83% <100.00%> (+0.08%)` | :arrow_up: |
   | [airflow/models/serialized\_dag.py](https://codecov.io/gh/apache/airflow/pull/7894/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvc2VyaWFsaXplZF9kYWcucHk=) | `94.18% <100.00%> (+1.78%)` | :arrow_up: |
   | ... and [16 more](https://codecov.io/gh/apache/airflow/pull/7894/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7894?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7894?src=pr&el=footer). Last update [da46243...f70677c](https://codecov.io/gh/apache/airflow/pull/7894?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services