You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/31 13:30:50 UTC

[GitHub] [apisix-dashboard] liuxiran opened a new pull request #433: Feat: dashboard support route group

liuxiran opened a new pull request #433:
URL: https://github.com/apache/apisix-dashboard/pull/433


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   fix issue: #431 
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   - add a menu item `routeGroup`,  support CRUD and List：
   ![2020-08-31 21-27-29屏幕截图](https://user-images.githubusercontent.com/2561857/91725165-ebcc9680-ebd0-11ea-9dc7-6ae02f70e976.png)
   ![2020-08-31 21-27-50屏幕截图](https://user-images.githubusercontent.com/2561857/91725172-ee2ef080-ebd0-11ea-87b7-7c55c9d85a86.png)
   ![2020-08-31 21-28-13屏幕截图](https://user-images.githubusercontent.com/2561857/91725181-eff8b400-ebd0-11ea-934c-6934105ab451.png)
   
   - create route support select route group:
   ![2020-08-31 21-29-45屏幕截图](https://user-images.githubusercontent.com/2561857/91725300-1f0f2580-ebd1-11ea-82fd-a03c3a8d3b99.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #433: Feat: dashboard support route group

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #433:
URL: https://github.com/apache/apisix-dashboard/pull/433#issuecomment-686275843


   waiting for #432 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #433: Feat: dashboard support route group

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #433:
URL: https://github.com/apache/apisix-dashboard/pull/433


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #433: Feat: dashboard support route group

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #433:
URL: https://github.com/apache/apisix-dashboard/pull/433#discussion_r484752952



##########
File path: config/routes.ts
##########
@@ -35,6 +35,18 @@ const routes = [
     path: '/routes/:rid/edit',
     component: './Route/Create',
   },
+  {
+    path: '/routegroup/list',
+    component: './RouteGroup/List',
+  },
+  {
+    path: 'routegroup/create',

Review comment:
       `/routegroup/xx`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #433: Feat: dashboard support route group

Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #433:
URL: https://github.com/apache/apisix-dashboard/pull/433#discussion_r485370090



##########
File path: src/pages/RouteGroup/components/Step1.tsx
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react';
+import { Form, Input } from 'antd';
+import { FormInstance } from 'antd/lib/form';
+import { useIntl } from 'umi';
+
+import { FORM_ITEM_LAYOUT } from '@/pages/Upstream/constants';
+
+type Props = {
+  form: FormInstance;
+  disabled?: boolean;
+};
+
+const initialValues = {
+  name: '',
+  description: '',
+};
+
+const Step1: React.FC<Props> = ({ form, disabled }) => {
+  const { formatMessage } = useIntl();
+  return (
+    <Form {...FORM_ITEM_LAYOUT} form={form} initialValues={initialValues}>
+      <Form.Item
+        label={formatMessage({ id: 'routegroup.step.name' })}
+        name="name"
+        rules={[{ required: true }]}
+        extra={formatMessage({ id: 'upstream.step.name.should.unique' })}

Review comment:
       should be `routegroup.step.name.should.unique`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on pull request #433: Feat: dashboard support route group

Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #433:
URL: https://github.com/apache/apisix-dashboard/pull/433#issuecomment-688669129


   this pr will  fix: https://github.com/apache/apisix-dashboard/issues/452


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #433: Feat: dashboard support route group

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #433:
URL: https://github.com/apache/apisix-dashboard/pull/433#issuecomment-688720897


   cc @LiteSun 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #433: Feat: dashboard support route group

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #433:
URL: https://github.com/apache/apisix-dashboard/pull/433#issuecomment-689477819


   cc @LiteSun 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #433: Feat: dashboard support route group

Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on pull request #433:
URL: https://github.com/apache/apisix-dashboard/pull/433#issuecomment-688669129


   this pr will  fix: https://github.com/apache/apisix-dashboard/issues/452 @juzhiyuan 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #433: Feat: dashboard support route group

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #433:
URL: https://github.com/apache/apisix-dashboard/pull/433#discussion_r484762283



##########
File path: config/routes.ts
##########
@@ -35,6 +35,18 @@ const routes = [
     path: '/routes/:rid/edit',
     component: './Route/Create',
   },
+  {
+    path: '/routegroup/list',
+    component: './RouteGroup/List',
+  },
+  {
+    path: 'routegroup/create',

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #433: Feat: dashboard support route group

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #433:
URL: https://github.com/apache/apisix-dashboard/pull/433#discussion_r485506244



##########
File path: src/pages/RouteGroup/components/Step1.tsx
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react';
+import { Form, Input } from 'antd';
+import { FormInstance } from 'antd/lib/form';
+import { useIntl } from 'umi';
+
+import { FORM_ITEM_LAYOUT } from '@/pages/Upstream/constants';
+
+type Props = {
+  form: FormInstance;
+  disabled?: boolean;
+};
+
+const initialValues = {
+  name: '',
+  description: '',
+};
+
+const Step1: React.FC<Props> = ({ form, disabled }) => {
+  const { formatMessage } = useIntl();
+  return (
+    <Form {...FORM_ITEM_LAYOUT} form={form} initialValues={initialValues}>
+      <Form.Item
+        label={formatMessage({ id: 'routegroup.step.name' })}
+        name="name"
+        rules={[{ required: true }]}
+        extra={formatMessage({ id: 'upstream.step.name.should.unique' })}

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org