You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/01/08 08:24:31 UTC
[kudu-CR] KUDU-2565: pass IOContext to ValidateDeltaOrder
Hello Adar Dembo, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12178
to review the following change.
Change subject: KUDU-2565: pass IOContext to ValidateDeltaOrder
......................................................................
KUDU-2565: pass IOContext to ValidateDeltaOrder
Previously, checksum errors that occurred during calls to the debug-only
function ValidateDeltaOrder() would lead to a DCHECK failure. This patch
plumbs an IOContext to these calls to avoid this and adds a regression
test for such cases.
Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
---
M src/kudu/tablet/delta_compaction.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
6 files changed, 54 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/12178/1
--
To view, visit http://gerrit.cloudera.org:8080/12178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
Gerrit-Change-Number: 12178
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12178 )
Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder
......................................................................
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12178/2/src/kudu/tablet/delta_tracker.cc
File src/kudu/tablet/delta_tracker.cc:
http://gerrit.cloudera.org:8080/#/c/12178/2/src/kudu/tablet/delta_tracker.cc@207
PS2, Line 207: #ifndef NDEBUG
: Status DeltaTracker::ValidateDeltaOrder(const std::shared_ptr<DeltaStore>& first,
: const std::shared_ptr<DeltaStore>& second,
: const IOContext* io_context,
: DeltaType type) {
: shared_ptr<DeltaStore> first_copy = first;
: shared_ptr<DeltaStore> second_copy = second;
:
: // Make clones so we don't leave the original ones initted. That can affect
: // tests. We know it's a DeltaFileReader if it's not Initted().
: if (!first_copy->Initted()) {
: shared_ptr<DeltaFileReader> first_clone;
: RETURN_NOT_OK(down_cast<DeltaFileReader*>(first.get())->CloneForDebugging(
: rowset_metadata_->fs_manager(), mem_trackers_.tablet_tracker, &first_clone));
: RETURN_NOT_OK(first_clone->Init(io_context));
: first_copy = first_clone;
: }
: if (!second_copy->Initted()) {
: shared_ptr<DeltaFileReader> second_clone;
: RETURN_NOT_OK(down_cast<DeltaFileReader*>(second.get())->CloneForDebugging(
: rowset_metadata_->fs_manager(), mem_trackers_.tablet_tracker, &second_clone));
: RETURN_NOT_OK(second_clone->Init(io_context));
: second_copy = second_clone;
: }
:
: switch (type) {
: case REDO:
: DCHECK_LE(first_copy->delta_stats().min_timestamp(),
: second_copy->delta_stats().min_timestamp())
: << "Found out-of-order deltas: [{" << first_copy->ToString() << "}, {"
: << second_copy->ToString() << "}]: type = " << type;
: break;
: case UNDO:
: DCHECK_GE(first_copy->delta_stats().min_timestamp(),
: second_copy->delta_stats().min_timestamp())
: << "Found out-of-order deltas: [{" << first_copy->ToString() << "}, {"
: << second_copy->ToString() << "}]: type = " << type;
: break;
: }
: return Status::OK();
: }
:
: Status DeltaTracker::ValidateDeltasOrdered(const SharedDeltaStoreVector& list,
: const IOContext* io_context,
: DeltaType type) {
: for (size_t i = 1; i < list.size(); i++) {
: RETURN_NOT_OK(ValidateDeltaOrder(list[i - 1], list[i], io_context, type));
: }
:
> If this is not used elsewhere but only in ifndef NDEBUG case, maybe put tho
Done
http://gerrit.cloudera.org:8080/#/c/12178/2/src/kudu/tablet/major_delta_compaction-test.cc
File src/kudu/tablet/major_delta_compaction-test.cc:
http://gerrit.cloudera.org:8080/#/c/12178/2/src/kudu/tablet/major_delta_compaction-test.cc@186
PS2, Line 186: const
> nit: constexpr ?
Done
http://gerrit.cloudera.org:8080/#/c/12178/2/src/kudu/tablet/major_delta_compaction-test.cc@191
PS2, Line 191: .empty());
> paranoid nit: is it guaranteed that all_rowsets container is non-empty?
It should be guaranteed because we've written to the tablet, but I'll add one anyway.
http://gerrit.cloudera.org:8080/#/c/12178/2/src/kudu/tablet/major_delta_compaction-test.cc@205
PS2, Line 205: Status s = tablet()->DoMajorDeltaCompaction(col_ids, rs, &io_context);
> nit: maybe, add ' << s.ToString(); for easier debugging if that fails
Done
--
To view, visit http://gerrit.cloudera.org:8080/12178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
Gerrit-Change-Number: 12178
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Jan 2019 22:11:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12178 )
Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/12178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
Gerrit-Change-Number: 12178
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Jan 2019 22:20:31 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12178 )
Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder
......................................................................
Patch Set 2:
(4 comments)
A few nits
http://gerrit.cloudera.org:8080/#/c/12178/2/src/kudu/tablet/delta_tracker.cc
File src/kudu/tablet/delta_tracker.cc:
http://gerrit.cloudera.org:8080/#/c/12178/2/src/kudu/tablet/delta_tracker.cc@207
PS2, Line 207: Status DeltaTracker::ValidateDeltaOrder(const std::shared_ptr<DeltaStore>& first,
: const std::shared_ptr<DeltaStore>& second,
: const IOContext* io_context,
: DeltaType type) {
: shared_ptr<DeltaStore> first_copy = first;
: shared_ptr<DeltaStore> second_copy = second;
:
: // Make clones so we don't leave the original ones initted. That can affect
: // tests. We know it's a DeltaFileReader if it's not Initted().
: if (!first_copy->Initted()) {
: shared_ptr<DeltaFileReader> first_clone;
: RETURN_NOT_OK(down_cast<DeltaFileReader*>(first.get())->CloneForDebugging(
: rowset_metadata_->fs_manager(), mem_trackers_.tablet_tracker, &first_clone));
: RETURN_NOT_OK(first_clone->Init(io_context));
: first_copy = first_clone;
: }
: if (!second_copy->Initted()) {
: shared_ptr<DeltaFileReader> second_clone;
: RETURN_NOT_OK(down_cast<DeltaFileReader*>(second.get())->CloneForDebugging(
: rowset_metadata_->fs_manager(), mem_trackers_.tablet_tracker, &second_clone));
: RETURN_NOT_OK(second_clone->Init(io_context));
: second_copy = second_clone;
: }
:
: switch (type) {
: case REDO:
: DCHECK_LE(first_copy->delta_stats().min_timestamp(),
: second_copy->delta_stats().min_timestamp())
: << "Found out-of-order deltas: [{" << first_copy->ToString() << "}, {"
: << second_copy->ToString() << "}]: type = " << type;
: break;
: case UNDO:
: DCHECK_GE(first_copy->delta_stats().min_timestamp(),
: second_copy->delta_stats().min_timestamp())
: << "Found out-of-order deltas: [{" << first_copy->ToString() << "}, {"
: << second_copy->ToString() << "}]: type = " << type;
: break;
: }
: return Status::OK();
: }
:
: Status DeltaTracker::ValidateDeltasOrdered(const SharedDeltaStoreVector& list,
: const IOContext* io_context,
: DeltaType type) {
: for (size_t i = 1; i < list.size(); i++) {
: RETURN_NOT_OK(ValidateDeltaOrder(list[i - 1], list[i], io_context, type));
: }
: return Status::OK();
: }
If this is not used elsewhere but only in ifndef NDEBUG case, maybe put those under '#ifndef NDEBUG' as well?
http://gerrit.cloudera.org:8080/#/c/12178/2/src/kudu/tablet/major_delta_compaction-test.cc
File src/kudu/tablet/major_delta_compaction-test.cc:
http://gerrit.cloudera.org:8080/#/c/12178/2/src/kudu/tablet/major_delta_compaction-test.cc@186
PS2, Line 186: const
nit: constexpr ?
http://gerrit.cloudera.org:8080/#/c/12178/2/src/kudu/tablet/major_delta_compaction-test.cc@191
PS2, Line 191: all_rowsets.front();
paranoid nit: is it guaranteed that all_rowsets container is non-empty? If not, maybe add ASSERT_FALSE(all_rowsets.empty())?
http://gerrit.cloudera.org:8080/#/c/12178/2/src/kudu/tablet/major_delta_compaction-test.cc@205
PS2, Line 205: ASSERT_TRUE(s.IsCorruption());
nit: maybe, add ' << s.ToString(); for easier debugging if that fails
--
To view, visit http://gerrit.cloudera.org:8080/12178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
Gerrit-Change-Number: 12178
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Jan 2019 18:05:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12178 )
Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder
......................................................................
Patch Set 2: Verified+1
The failure seems unrelated:
RaftConsensusNonVoterITest.PromoteAndDemote
--
To view, visit http://gerrit.cloudera.org:8080/12178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
Gerrit-Change-Number: 12178
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Jan 2019 16:49:27 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12178
to look at the new patch set (#2).
Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder
......................................................................
KUDU-2656: pass IOContext to ValidateDeltaOrder
Previously, checksum errors that occurred during calls to the debug-only
function ValidateDeltaOrder() would lead to a DCHECK failure. This patch
plumbs an IOContext to these calls to avoid this and adds a regression
test for such cases.
Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
---
M src/kudu/tablet/delta_compaction.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
6 files changed, 55 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/12178/2
--
To view, visit http://gerrit.cloudera.org:8080/12178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
Gerrit-Change-Number: 12178
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12178 )
Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder
......................................................................
Patch Set 2: Code-Review+1
Nothing to add to Alexey's comments.
--
To view, visit http://gerrit.cloudera.org:8080/12178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
Gerrit-Change-Number: 12178
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Jan 2019 18:51:04 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12178
to look at the new patch set (#3).
Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder
......................................................................
KUDU-2656: pass IOContext to ValidateDeltaOrder
Previously, checksum errors that occurred during calls to the debug-only
function ValidateDeltaOrder() would lead to a DCHECK failure. This patch
plumbs an IOContext to these calls to avoid this and adds a regression
test for such cases.
Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
---
M src/kudu/tablet/delta_compaction.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
6 files changed, 59 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/12178/3
--
To view, visit http://gerrit.cloudera.org:8080/12178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
Gerrit-Change-Number: 12178
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder
......................................................................
Removed -Verified by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
Gerrit-Change-Number: 12178
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12178
to look at the new patch set (#4).
Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder
......................................................................
KUDU-2656: pass IOContext to ValidateDeltaOrder
Previously, checksum errors that occurred during calls to the debug-only
function ValidateDeltaOrder() would lead to a DCHECK failure. This patch
plumbs an IOContext to these calls to avoid this and adds a regression
test for such cases.
Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
---
M src/kudu/tablet/delta_compaction.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
6 files changed, 60 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/12178/4
--
To view, visit http://gerrit.cloudera.org:8080/12178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
Gerrit-Change-Number: 12178
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12178 )
Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
Gerrit-Change-Number: 12178
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 09 Jan 2019 06:49:18 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12178 )
Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder
......................................................................
KUDU-2656: pass IOContext to ValidateDeltaOrder
Previously, checksum errors that occurred during calls to the debug-only
function ValidateDeltaOrder() would lead to a DCHECK failure. This patch
plumbs an IOContext to these calls to avoid this and adds a regression
test for such cases.
Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
Reviewed-on: http://gerrit.cloudera.org:8080/12178
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tablet/delta_compaction.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
6 files changed, 60 insertions(+), 13 deletions(-)
Approvals:
Adar Dembo: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
Gerrit-Change-Number: 12178
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2656: pass IOContext to ValidateDeltaOrder
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: KUDU-2656: pass IOContext to ValidateDeltaOrder
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3364ad95a5b3608db6538151007c4b6d16500f2b
Gerrit-Change-Number: 12178
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)