You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/02/04 13:39:03 UTC

[GitHub] [carbondata] jackylk commented on a change in pull request #3600: [CARBONDATA-3678] optimize list files in insert stage

jackylk commented on a change in pull request #3600: [CARBONDATA-3678] optimize list files in insert stage
URL: https://github.com/apache/carbondata/pull/3600#discussion_r374674044
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datastore/filesystem/CarbonFile.java
 ##########
 @@ -33,6 +33,9 @@
 
   CarbonFile[] listFiles();
 
+  CarbonFile[] listCarbonFilesByCountIterator(boolean recursive, String path, int fileCount)
 
 Review comment:
   CarbonFile already has a 'path', what is the parameter 'path'? It is confusing if there is no function description in comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services