You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/04/08 13:11:00 UTC
[jira] [Work logged] (HADOOP-18196) Remove replace-guava from replacer plugin
[ https://issues.apache.org/jira/browse/HADOOP-18196?focusedWorklogId=754578&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-754578 ]
ASF GitHub Bot logged work on HADOOP-18196:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/22 13:10
Start Date: 08/Apr/22 13:10
Worklog Time Spent: 10m
Work Description: virajjasani opened a new pull request, #4152:
URL: https://github.com/apache/hadoop/pull/4152
### Description of PR
While running the build, realized that all replacer plugin executions run only after "banned-illegal-imports" enforcer plugin.
For instance,
```
[INFO] -
Issue Time Tracking
-------------------
Worklog Id: (was: 754578)
Remaining Estimate: 0h
Time Spent: 10m
> Remove replace-guava from replacer plugin
> -----------------------------------------
>
> Key: HADOOP-18196
> URL: https://issues.apache.org/jira/browse/HADOOP-18196
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While running the build, realized that all replacer plugin executions run only after "banned-illegal-imports" enforcer plugin.
> For instance,
> {code:java}
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (banned-illegal-imports) @ hadoop-cloud-storage ---
> [INFO]
> [INFO] --- replacer:1.5.3:replace (replace-generated-sources) @ hadoop-cloud-storage ---
> [INFO] Skipping
> [INFO]
> [INFO] --- replacer:1.5.3:replace (replace-sources) @ hadoop-cloud-storage ---
> [INFO] Skipping
> [INFO]
> [INFO] --- replacer:1.5.3:replace (replace-guava) @ hadoop-cloud-storage ---
> [INFO] Replacement run on 0 file.
> [INFO] {code}
> Hence, if our source code uses com.google.common, banned-illegal-imports will cause the build failure and replacer plugin would not even get executed.
> We should remove it as it is only redundant execution step.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org