[jira] [Commented] (AIRFLOW-5553) mysql_to_gcs.MySqlToGoogleCloudStorageOperator binary values cannot be encoded whenever a BQ schema is not explicitly specified

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937973#comment-16937973 ] 

ASF GitHub Bot commented on AIRFLOW-5553:
-----------------------------------------

stoynov96 commented on pull request #6183: [AIRFLOW-5553] Bytes value check done based on the type of the variable
URL: https://github.com/apache/airflow/pull/6183
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5553
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   Changed the condition to decode bytes values so they will now be dealt with without having to specify a BQ schema
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   It's a trivial one line change adding a single condition to do the same task that had been done before.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> mysql_to_gcs.MySqlToGoogleCloudStorageOperator binary values cannot be encoded whenever a BQ schema is not explicitly specified
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5553
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5553
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators
>    Affects Versions: 1.10.3, 1.10.4, 1.10.5
>            Reporter: Nikolay Stoynov
>            Assignee: Nikolay Stoynov
>            Priority: Minor
>              Labels: easyfix
>
>  
> The MySqlGoogleCloudStorageOperator currently deals with `bytes` values. However, the way it detects when a value is of type `bytes` is dependent on the column type in the BQ schema provided.
> Therefore, whenever a BQ schema is not provided, the value is not dealt with and a serialization issue occurs:
> {noformat}
> [2018-10-11 17:59:36,056] INFO airflow.task.task_runner.bash_task_runner.BashTaskRunner _read_task_logs - Job 11906: Subtask my_subtask TypeError: Object of type 'bytes' is not JSON serializable{noformat}
> This should be a trivial fix but needs to be addressed so that the check for a bytes value is based on the type of the variable too.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)