You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/10/28 01:37:50 UTC
Review Request 63391: Fixed the flaky
SlaveTest.HTTPSchedulerSlaveRestart.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63391/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-7972
https://issues.apache.org/jira/browse/MESOS-7972
Repository: mesos
Description
-------
This test was trying to prevent re-registration retries, but
it resumed the clock too early! As a result, sometimes a second
re-registration occurs and the master will send an
UpdateFrameworkMessage that over-rules the one we're spoofing
in the test. One example occurs in MESOS-7972, and the agent
as a result replies directly to the scheduler since it sees
the scheduler as having a pid.
Diffs
-----
src/tests/slave_tests.cpp 99b9c8222d0c15e42b2d8d6672bc197dcb37b359
Diff: https://reviews.apache.org/r/63391/diff/1/
Testing
-------
Ran in repetition.
Thanks,
Benjamin Mahler
Re: Review Request 63391: Fixed the flaky
SlaveTest.HTTPSchedulerSlaveRestart.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63391/#review189554
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Oct. 28, 2017, 1:37 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63391/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2017, 1:37 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-7972
> https://issues.apache.org/jira/browse/MESOS-7972
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was trying to prevent re-registration retries, but
> it resumed the clock too early! As a result, sometimes a second
> re-registration occurs and the master will send an
> UpdateFrameworkMessage that over-rules the one we're spoofing
> in the test. One example occurs in MESOS-7972, and the agent
> as a result replies directly to the scheduler since it sees
> the scheduler as having a pid.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 99b9c8222d0c15e42b2d8d6672bc197dcb37b359
>
>
> Diff: https://reviews.apache.org/r/63391/diff/1/
>
>
> Testing
> -------
>
> Ran in repetition.
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 63391: Fixed the flaky
SlaveTest.HTTPSchedulerSlaveRestart.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63391/#review189533
-----------------------------------------------------------
PASS: Mesos patch 63391 was successfully built and tested.
Reviews applied: `['63391']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63391
- Mesos Reviewbot Windows
On Oct. 28, 2017, 1:37 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63391/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2017, 1:37 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-7972
> https://issues.apache.org/jira/browse/MESOS-7972
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was trying to prevent re-registration retries, but
> it resumed the clock too early! As a result, sometimes a second
> re-registration occurs and the master will send an
> UpdateFrameworkMessage that over-rules the one we're spoofing
> in the test. One example occurs in MESOS-7972, and the agent
> as a result replies directly to the scheduler since it sees
> the scheduler as having a pid.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 99b9c8222d0c15e42b2d8d6672bc197dcb37b359
>
>
> Diff: https://reviews.apache.org/r/63391/diff/1/
>
>
> Testing
> -------
>
> Ran in repetition.
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 63391: Fixed the flaky
SlaveTest.HTTPSchedulerSlaveRestart.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63391/#review189505
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63391]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 28, 2017, 1:37 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63391/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2017, 1:37 a.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-7972
> https://issues.apache.org/jira/browse/MESOS-7972
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test was trying to prevent re-registration retries, but
> it resumed the clock too early! As a result, sometimes a second
> re-registration occurs and the master will send an
> UpdateFrameworkMessage that over-rules the one we're spoofing
> in the test. One example occurs in MESOS-7972, and the agent
> as a result replies directly to the scheduler since it sees
> the scheduler as having a pid.
>
>
> Diffs
> -----
>
> src/tests/slave_tests.cpp 99b9c8222d0c15e42b2d8d6672bc197dcb37b359
>
>
> Diff: https://reviews.apache.org/r/63391/diff/1/
>
>
> Testing
> -------
>
> Ran in repetition.
>
>
> Thanks,
>
> Benjamin Mahler
>
>