You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2012/12/12 12:05:23 UTC

[jira] [Commented] (ZOOKEEPER-1513) "Unreasonable length" exception while starting a server.

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529834#comment-13529834 ] 

Hudson commented on ZOOKEEPER-1513:
-----------------------------------

Integrated in ZooKeeper-trunk #1770 (See [https://builds.apache.org/job/ZooKeeper-trunk/1770/])
    ZOOKEEPER-1513. "Unreasonable length" exception while starting a server (Skye W-M via phunt) (Revision 1420538)

     Result = SUCCESS
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1420538
Files : 
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/build.xml
* /zookeeper/trunk/src/java/main/org/apache/jute/BinaryInputArchive.java
* /zookeeper/trunk/src/java/test/data/buffersize
* /zookeeper/trunk/src/java/test/data/buffersize/create
* /zookeeper/trunk/src/java/test/data/buffersize/create/version-2
* /zookeeper/trunk/src/java/test/data/buffersize/create/version-2/log.1
* /zookeeper/trunk/src/java/test/data/buffersize/create/version-2/snapshot.0
* /zookeeper/trunk/src/java/test/data/buffersize/set
* /zookeeper/trunk/src/java/test/data/buffersize/set/version-2
* /zookeeper/trunk/src/java/test/data/buffersize/set/version-2/log.1
* /zookeeper/trunk/src/java/test/data/buffersize/set/version-2/snapshot.0
* /zookeeper/trunk/src/java/test/data/buffersize/snapshot
* /zookeeper/trunk/src/java/test/data/buffersize/snapshot/version-2
* /zookeeper/trunk/src/java/test/data/buffersize/snapshot/version-2/log.1
* /zookeeper/trunk/src/java/test/data/buffersize/snapshot/version-2/snapshot.0
* /zookeeper/trunk/src/java/test/data/buffersize/snapshot/version-2/snapshot.2
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/BufferSizeTest.java

                
> "Unreasonable length" exception while starting a server.
> --------------------------------------------------------
>
>                 Key: ZOOKEEPER-1513
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1513
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.3.4
>            Reporter: Patrick Hunt
>            Assignee: Skye Wanderman-Milne
>             Fix For: 3.5.0, 3.4.6
>
>         Attachments: ZOOKEEPER-1513_2012.10.17.patch, ZOOKEEPER-1513_2012.10.17_take2.patch, ZOOKEEPER-1513_2012.10.17_take2.tar.gz, ZOOKEEPER-1513.patch
>
>
> The server is allowing a client to set data larger than the server can then later read:
> {noformat}
> 2012-07-18 14:28:12,555 - FATAL [main:QuorumPeer@400] - Unable to load database on disk 
> java.io.IOException: Unreasonable length = 1048583 
> at org.apache.jute.BinaryInputArchive.readBuffer(BinaryInputArchive.java:100) 
> at org.apache.zookeeper.server.persistence.Util.readTxnBytes(Util.java:232) 
> at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.next(FileTxnLog.java:602) 
> at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.init(FileTxnLog.java:529) 
> at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.<init>(FileTxnLog.java:504) 
> at org.apache.zookeeper.server.persistence.FileTxnLog.read(FileTxnLog.java:341) 
> at org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:131) 
> at org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:222) 
> at org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:398) 
> at org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:143) 
> at org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:103) 
> at org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:76) 
> 2012-07-18 14:28:12,555 - FATAL [main:QuorumPeerMain@87] - Unexpected exception, exiting abnormally 
> java.lang.RuntimeException: Unable to run quorum server 
> at org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:401) 
> at org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:143) 
> at org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:103) 
> at org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:76) 
> Caused by: java.io.IOException: Unreasonable length = 1048583 
> at org.apache.jute.BinaryInputArchive.readBuffer(BinaryInputArchive.java:100) 
> at org.apache.zookeeper.server.persistence.Util.readTxnBytes(Util.java:232) 
> at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.next(FileTxnLog.java:602) 
> at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.init(FileTxnLog.java:529) 
> at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.<init>(FileTxnLog.java:504) 
> at org.apache.zookeeper.server.persistence.FileTxnLog.read(FileTxnLog.java:341) 
> at org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:131) 
> at org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:222) 
> at org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:398) 
> ... 3 more
> {noformat}
> Notice the size is 0x100007 - 7 bytes beyond.
> The SetDataTxn contains the client data + a couple extra fields. On ingest the server is applying the jute.maxbuffer size to the data (expected) but not handling the fact that the data plus these extra fields may exceed the jute.maxbuffer check when reading from disk.
> Workaround was simple here: set the jute.maxbuffer size a bit higher (and fix the mis-behaving client, expectation was not that the data would grow this large).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira