You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/03 06:17:35 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
villebro opened a new pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.02%`.
> The diff coverage is `56.89%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 70.34% -1.03%
==========================================
Files 585 585
Lines 30987 30922 -65
Branches 3267 3269 +2
==========================================
- Hits 22116 21753 -363
- Misses 8760 9058 +298
Partials 111 111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.94% <37.83%> (-0.04%)` | :arrow_down: |
| #javascript | `59.35% <45.94%> (-0.06%)` | :arrow_down: |
| #python | `69.87% <71.42%> (-1.71%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `89.88% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `74.24% <41.66%> (-7.41%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `61.45% <66.66%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.42% <100.00%> (-7.90%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...fbc1dbb](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `6.00%`.
> The diff coverage is `56.45%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 65.36% -6.01%
==========================================
Files 585 585
Lines 30987 30926 -61
Branches 3267 3272 +5
==========================================
- Hits 22116 20215 -1901
- Misses 8760 10530 +1770
- Partials 111 181 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.35% <48.78%> (-0.05%)` | :arrow_down: |
| #python | `69.62% <71.42%> (-1.97%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `67.41% <0.00%> (-22.48%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `50.00% <0.00%> (-26.32%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `68.93% <41.66%> (-12.72%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.27% <70.00%> (-11.56%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...76f5371](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1001c6d5f482f4950ef45317efab87ad203dd7d4&el=desc) will **decrease** coverage by `11.95%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
===========================================
- Coverage 71.35% 59.40% -11.96%
===========================================
Files 585 401 -184
Lines 30917 12762 -18155
Branches 3246 3246
===========================================
- Hits 22061 7581 -14480
+ Misses 8747 5002 -3745
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.40% <50.00%> (+<0.01%)` | :arrow_up: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `67.41% <0.00%> (-22.48%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `50.00% <0.00%> (-26.32%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <50.00%> (-10.76%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| [...nd/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `76.14% <100.00%> (-5.51%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [327 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [1001c6d...dcf2895](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `12.01%`.
> The diff coverage is `48.78%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
===========================================
- Coverage 71.37% 59.35% -12.02%
===========================================
Files 585 401 -184
Lines 30987 12829 -18158
Branches 3267 3272 +5
===========================================
- Hits 22116 7615 -14501
+ Misses 8760 5033 -3727
- Partials 111 181 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.35% <48.78%> (-0.05%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `67.41% <0.00%> (-22.48%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `50.00% <0.00%> (-26.32%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `68.93% <41.66%> (-12.72%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.27% <70.00%> (-11.56%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| [...nd/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [324 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...76f5371](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1001c6d5f482f4950ef45317efab87ad203dd7d4&el=desc) will **decrease** coverage by `11.94%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
===========================================
- Coverage 71.35% 59.40% -11.95%
===========================================
Files 585 401 -184
Lines 30917 12763 -18154
Branches 3246 3247 +1
===========================================
- Hits 22061 7582 -14479
+ Misses 8747 5002 -3745
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.40% <50.00%> (+0.01%)` | :arrow_up: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `67.41% <0.00%> (-22.48%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `50.00% <0.00%> (-26.32%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <50.00%> (-10.76%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| [...nd/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `76.14% <100.00%> (-5.51%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [327 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [1001c6d...8f15bbd](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.49%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 69.87% -1.50%
==========================================
Files 585 184 -401
Lines 30987 18097 -12890
Branches 3267 0 -3267
==========================================
- Hits 22116 12646 -9470
+ Misses 8760 5451 -3309
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.87% <71.42%> (-1.71%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| [superset/views/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `63.63% <0.00%> (-2.08%)` | :arrow_down: |
| ... and [405 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...b3fe446](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1001c6d5f482f4950ef45317efab87ad203dd7d4&el=desc) will **decrease** coverage by `1.15%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.35% 70.20% -1.16%
==========================================
Files 585 585
Lines 30917 30904 -13
Branches 3246 3247 +1
==========================================
- Hits 22061 21695 -366
- Misses 8747 9094 +347
- Partials 109 115 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.22% <42.85%> (-0.85%)` | :arrow_down: |
| #javascript | `59.40% <50.00%> (+0.01%)` | :arrow_up: |
| #python | `69.89% <ø> (-1.62%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `89.88% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.09% <ø> (-14.88%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `62.36% <50.00%> (+0.53%)` | :arrow_up: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `76.31% <100.00%> (ø)` | |
| [...nd/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `81.65% <100.00%> (ø)` | |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [1001c6d...8f15bbd](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `7.58%`.
> The diff coverage is `50.84%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 63.79% -7.59%
==========================================
Files 585 531 -54
Lines 30987 29575 -1412
Branches 3267 2888 -379
==========================================
- Hits 22116 18866 -3250
- Misses 8760 10532 +1772
- Partials 111 177 +66
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.92% <39.47%> (-0.06%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `69.97% <71.42%> (-1.62%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `5.00% <0.00%> (-68.75%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `84.26% <0.00%> (-5.62%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `48.12% <36.00%> (-33.54%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `46.66% <50.00%> (-15.17%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.42% <100.00%> (-7.90%)` | :arrow_down: |
| ... and [223 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...1f436ec](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.74%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 69.62% -1.75%
==========================================
Files 585 184 -401
Lines 30987 18097 -12890
Branches 3267 0 -3267
==========================================
- Hits 22116 12600 -9516
+ Misses 8760 5497 -3263
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.62% <71.42%> (-1.97%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| ... and [415 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...b3fe446](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#discussion_r435114981
##########
File path: tests/core_tests.py
##########
@@ -161,24 +161,6 @@ def test_get_superset_tables_not_found(self):
rv = self.client.get(uri)
self.assertEqual(rv.status_code, 404)
- def test_old_slice_json_endpoint(self):
Review comment:
These tests are no longer applicable, as the backend is not able to infer 1) which endpoint to call 2) what the final request payload will look like (this is handled by `buildQuery.{j,t}s` in the plugin). Going forward all these tests will reside in the viz plugin, with the backend tests ensuring that valid chart data requests get valid responses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `5.83%`.
> The diff coverage is `56.45%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 65.54% -5.84%
==========================================
Files 585 585
Lines 30987 31008 +21
Branches 3267 3272 +5
==========================================
- Hits 22116 20323 -1793
- Misses 8760 10504 +1744
- Partials 111 181 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.35% <48.78%> (-0.05%)` | :arrow_down: |
| #python | `69.90% <71.42%> (-1.69%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `67.41% <0.00%> (-22.48%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `50.00% <0.00%> (-26.32%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `68.93% <41.66%> (-12.72%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.27% <70.00%> (-11.56%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| ... and [159 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...76f5371](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `5.82%`.
> The diff coverage is `60.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 65.54% -5.83%
==========================================
Files 585 585
Lines 30987 31013 +26
Branches 3267 3274 +7
==========================================
- Hits 22116 20327 -1789
- Misses 8760 10505 +1745
- Partials 111 181 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.36% <55.10%> (-0.04%)` | :arrow_down: |
| #python | `69.90% <71.42%> (-1.69%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `67.41% <0.00%> (-22.48%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `50.00% <0.00%> (-26.32%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `69.34% <53.12%> (-12.31%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.27% <70.00%> (-11.56%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| ... and [159 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...b7fac28](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `7.91%`.
> The diff coverage is `46.15%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 63.45% -7.92%
==========================================
Files 585 531 -54
Lines 30987 29579 -1408
Branches 3267 2892 -375
==========================================
- Hits 22116 18770 -3346
- Misses 8760 10623 +1863
- Partials 111 186 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.06% <34.09%> (-0.92%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `69.97% <71.42%> (-1.62%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `5.00% <0.00%> (-68.75%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `83.14% <0.00%> (-6.75%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `45.40% <25.00%> (-16.43%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `47.72% <36.00%> (-33.93%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.42% <100.00%> (-7.90%)` | :arrow_down: |
| ... and [225 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...b3fe446](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `0.98%`.
> The diff coverage is `61.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 70.38% -0.99%
==========================================
Files 585 585
Lines 30987 31013 +26
Branches 3267 3274 +7
==========================================
- Hits 22116 21828 -288
- Misses 8760 9073 +313
- Partials 111 112 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.83% <42.85%> (-0.15%)` | :arrow_down: |
| #javascript | `59.36% <55.10%> (-0.04%)` | :arrow_down: |
| #python | `69.97% <71.42%> (-1.62%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `88.76% <0.00%> (-1.13%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `74.45% <53.12%> (-7.20%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `61.74% <70.00%> (-0.08%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.42% <100.00%> (-7.90%)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...b7fac28](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `7.58%`.
> The diff coverage is `46.15%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 63.78% -7.59%
==========================================
Files 585 531 -54
Lines 30987 29579 -1408
Branches 3267 2892 -375
==========================================
- Hits 22116 18868 -3248
- Misses 8760 10534 +1774
- Partials 111 177 +66
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.92% <34.09%> (-0.07%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `69.97% <71.42%> (-1.62%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `5.00% <0.00%> (-68.75%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `84.26% <0.00%> (-5.62%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `45.40% <25.00%> (-16.43%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `47.72% <36.00%> (-33.93%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.42% <100.00%> (-7.90%)` | :arrow_down: |
| ... and [223 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...8b27a77](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.39%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 69.97% -1.40%
==========================================
Files 585 184 -401
Lines 30987 18179 -12808
Branches 3267 0 -3267
==========================================
- Hits 22116 12721 -9395
+ Misses 8760 5458 -3302
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.97% <71.42%> (-1.62%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.77% <0.00%> (-1.80%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.27% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.91% <0.00%> (-0.30%)` | :arrow_down: |
| ... and [397 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...b3fe446](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.46%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 69.90% -1.47%
==========================================
Files 585 184 -401
Lines 30987 18179 -12808
Branches 3267 0 -3267
==========================================
- Hits 22116 12708 -9408
+ Misses 8760 5471 -3289
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.90% <71.42%> (-1.69%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.62% <0.00%> (-1.95%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.42% <0.00%> (-0.88%)` | :arrow_down: |
| ... and [399 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...fbc1dbb](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.56%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 69.80% -1.57%
==========================================
Files 585 184 -401
Lines 30987 18097 -12890
Branches 3267 0 -3267
==========================================
- Hits 22116 12633 -9483
+ Misses 8760 5464 -3296
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.80% <71.42%> (-1.78%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| ... and [407 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...fbc1dbb](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.39%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 69.97% -1.40%
==========================================
Files 585 184 -401
Lines 30987 18179 -12808
Branches 3267 0 -3267
==========================================
- Hits 22116 12721 -9395
+ Misses 8760 5458 -3302
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.97% <71.42%> (-1.62%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.77% <0.00%> (-1.80%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.27% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.91% <0.00%> (-0.30%)` | :arrow_down: |
| ... and [397 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...fbc1dbb](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.49%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 69.87% -1.50%
==========================================
Files 585 184 -401
Lines 30987 18097 -12890
Branches 3267 0 -3267
==========================================
- Hits 22116 12645 -9471
+ Misses 8760 5452 -3308
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.87% <71.42%> (-1.72%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| ... and [406 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...b3fe446](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.22%`.
> The diff coverage is `56.89%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 70.14% -1.23%
==========================================
Files 585 585
Lines 30987 30922 -65
Branches 3267 3269 +2
==========================================
- Hits 22116 21691 -425
- Misses 8760 9114 +354
- Partials 111 117 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.16% <37.83%> (-0.82%)` | :arrow_down: |
| #javascript | `59.35% <45.94%> (-0.06%)` | :arrow_down: |
| #python | `69.87% <71.42%> (-1.71%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `89.88% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `74.24% <41.66%> (-7.41%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `61.45% <66.66%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.42% <100.00%> (-7.90%)` | :arrow_down: |
| ... and [30 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...fbc1dbb](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `5.85%`.
> The diff coverage is `55.17%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 65.51% -5.86%
==========================================
Files 585 585
Lines 30987 30922 -65
Branches 3267 3269 +2
==========================================
- Hits 22116 20258 -1858
- Misses 8760 10483 +1723
- Partials 111 181 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.35% <45.94%> (-0.06%)` | :arrow_down: |
| #python | `69.87% <71.42%> (-1.71%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `67.41% <0.00%> (-22.48%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `50.00% <0.00%> (-26.32%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `68.93% <41.66%> (-12.72%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `49.72% <66.66%> (-12.11%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| ... and [165 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...fbc1dbb](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.74%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 69.62% -1.75%
==========================================
Files 585 184 -401
Lines 30987 18097 -12890
Branches 3267 0 -3267
==========================================
- Hits 22116 12600 -9516
+ Misses 8760 5497 -3263
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.62% <71.42%> (-1.97%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| ... and [415 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...b7fac28](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1001c6d5f482f4950ef45317efab87ad203dd7d4&el=desc) will **decrease** coverage by `0.94%`.
> The diff coverage is `57.14%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.35% 70.41% -0.95%
==========================================
Files 585 585
Lines 30917 30904 -13
Branches 3246 3247 +1
==========================================
- Hits 22061 21760 -301
- Misses 8747 9035 +288
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.08% <42.85%> (+0.01%)` | :arrow_up: |
| #javascript | `59.40% <50.00%> (+0.01%)` | :arrow_up: |
| #python | `69.89% <ø> (-1.62%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `89.88% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.09% <ø> (-14.88%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `62.36% <50.00%> (+0.53%)` | :arrow_up: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `76.31% <100.00%> (ø)` | |
| [...nd/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `81.65% <100.00%> (ø)` | |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [1001c6d...8f15bbd](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `0.97%`.
> The diff coverage is `58.06%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 70.40% -0.98%
==========================================
Files 585 585
Lines 30987 31008 +21
Branches 3267 3272 +5
==========================================
- Hits 22116 21830 -286
- Misses 8760 9067 +307
Partials 111 111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.92% <34.14%> (-0.06%)` | :arrow_down: |
| #javascript | `59.35% <48.78%> (-0.05%)` | :arrow_down: |
| #python | `69.97% <71.42%> (-1.62%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `88.76% <0.00%> (-1.13%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `74.24% <41.66%> (-7.41%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `61.74% <70.00%> (-0.08%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.42% <100.00%> (-7.90%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...76f5371](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1001c6d5f482f4950ef45317efab87ad203dd7d4&el=desc) will **decrease** coverage by `5.99%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.35% 65.35% -6.00%
==========================================
Files 585 585
Lines 30917 30790 -127
Branches 3246 3247 +1
==========================================
- Hits 22061 20123 -1938
- Misses 8747 10488 +1741
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.40% <50.00%> (+0.01%)` | :arrow_up: |
| #python | `69.56% <ø> (-1.95%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `67.41% <0.00%> (-22.48%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `50.00% <0.00%> (-26.32%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.91% <ø> (-15.07%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `51.07% <50.00%> (-10.76%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| [...nd/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `76.14% <100.00%> (-5.51%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [183 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [1001c6d...8f15bbd](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.74%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 69.62% -1.75%
==========================================
Files 585 184 -401
Lines 30987 18097 -12890
Branches 3267 0 -3267
==========================================
- Hits 22116 12600 -9516
+ Misses 8760 5497 -3263
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.62% <71.42%> (-1.97%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| ... and [415 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...8b27a77](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `5.89%`.
> The diff coverage is `56.45%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 65.47% -5.90%
==========================================
Files 585 585
Lines 30987 30926 -61
Branches 3267 3272 +5
==========================================
- Hits 22116 20248 -1868
- Misses 8760 10497 +1737
- Partials 111 181 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.35% <48.78%> (-0.05%)` | :arrow_down: |
| #python | `69.80% <71.42%> (-1.78%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `67.41% <0.00%> (-22.48%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `50.00% <0.00%> (-26.32%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `68.93% <41.66%> (-12.72%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.27% <70.00%> (-11.56%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| ... and [167 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...76f5371](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.39%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 69.97% -1.40%
==========================================
Files 585 184 -401
Lines 30987 18179 -12808
Branches 3267 0 -3267
==========================================
- Hits 22116 12721 -9395
+ Misses 8760 5458 -3302
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.97% <71.42%> (-1.62%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.77% <0.00%> (-1.80%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.27% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.91% <0.00%> (-0.30%)` | :arrow_down: |
| ... and [397 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...8b27a77](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `7.88%`.
> The diff coverage is `46.15%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 63.49% -7.89%
==========================================
Files 585 531 -54
Lines 30987 29579 -1408
Branches 3267 2892 -375
==========================================
- Hits 22116 18780 -3336
- Misses 8760 10613 +1853
- Partials 111 186 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.14% <34.09%> (-0.84%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `69.97% <71.42%> (-1.62%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `5.00% <0.00%> (-68.75%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `84.26% <0.00%> (-5.62%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `45.40% <25.00%> (-16.43%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `47.72% <36.00%> (-33.93%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.42% <100.00%> (-7.90%)` | :arrow_down: |
| ... and [225 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...8b27a77](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.16%`.
> The diff coverage is `58.06%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 70.20% -1.17%
==========================================
Files 585 585
Lines 30987 31008 +21
Branches 3267 3272 +5
==========================================
- Hits 22116 21769 -347
- Misses 8760 9122 +362
- Partials 111 117 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.14% <34.14%> (-0.84%)` | :arrow_down: |
| #javascript | `59.35% <48.78%> (-0.05%)` | :arrow_down: |
| #python | `69.97% <71.42%> (-1.62%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `88.76% <0.00%> (-1.13%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `74.24% <41.66%> (-7.41%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `61.74% <70.00%> (-0.08%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.42% <100.00%> (-7.90%)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...76f5371](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.74%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 69.62% -1.75%
==========================================
Files 585 184 -401
Lines 30987 18097 -12890
Branches 3267 0 -3267
==========================================
- Hits 22116 12600 -9516
+ Misses 8760 5497 -3263
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.62% <71.42%> (-1.97%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| ... and [415 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...1fe48b0](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.22%`.
> The diff coverage is `61.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 70.15% -1.23%
==========================================
Files 585 585
Lines 30987 31013 +26
Branches 3267 3274 +7
==========================================
- Hits 22116 21756 -360
- Misses 8760 9140 +380
- Partials 111 117 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.08% <42.85%> (-0.90%)` | :arrow_down: |
| #javascript | `59.36% <55.10%> (-0.04%)` | :arrow_down: |
| #python | `69.90% <71.42%> (-1.69%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `88.76% <0.00%> (-1.13%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `74.45% <53.12%> (-7.20%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `61.74% <70.00%> (-0.08%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.42% <100.00%> (-7.90%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...b7fac28](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.03%`.
> The diff coverage is `61.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 70.34% -1.04%
==========================================
Files 585 585
Lines 30987 31013 +26
Branches 3267 3274 +7
==========================================
- Hits 22116 21815 -301
- Misses 8760 9086 +326
- Partials 111 112 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.83% <42.85%> (-0.15%)` | :arrow_down: |
| #javascript | `59.36% <55.10%> (-0.04%)` | :arrow_down: |
| #python | `69.90% <71.42%> (-1.69%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `88.76% <0.00%> (-1.13%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `74.45% <53.12%> (-7.20%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `61.74% <70.00%> (-0.08%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.42% <100.00%> (-7.90%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...b7fac28](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.74%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 69.62% -1.75%
==========================================
Files 585 184 -401
Lines 30987 18097 -12890
Branches 3267 0 -3267
==========================================
- Hits 22116 12600 -9516
+ Misses 8760 5497 -3263
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.62% <71.42%> (-1.97%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| ... and [415 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...fbc1dbb](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `7.58%`.
> The diff coverage is `46.15%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 63.78% -7.59%
==========================================
Files 585 531 -54
Lines 30987 29579 -1408
Branches 3267 2892 -375
==========================================
- Hits 22116 18867 -3249
- Misses 8760 10535 +1775
- Partials 111 177 +66
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.91% <34.09%> (-0.07%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `69.97% <71.42%> (-1.62%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `5.00% <0.00%> (-68.75%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `83.14% <0.00%> (-6.75%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `45.40% <25.00%> (-16.43%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `47.72% <36.00%> (-33.93%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `68.42% <100.00%> (-7.90%)` | :arrow_down: |
| ... and [223 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...b3fe446](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `6.00%`.
> The diff coverage is `60.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 65.36% -6.01%
==========================================
Files 585 585
Lines 30987 30931 -56
Branches 3267 3274 +7
==========================================
- Hits 22116 20219 -1897
- Misses 8760 10531 +1771
- Partials 111 181 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.36% <55.10%> (-0.04%)` | :arrow_down: |
| #python | `69.62% <71.42%> (-1.97%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `67.41% <0.00%> (-22.48%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `50.00% <0.00%> (-26.32%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `69.34% <53.12%> (-12.31%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.27% <70.00%> (-11.56%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...b7fac28](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.74%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 69.62% -1.75%
==========================================
Files 585 184 -401
Lines 30987 18097 -12890
Branches 3267 0 -3267
==========================================
- Hits 22116 12600 -9516
+ Misses 8760 5497 -3263
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.62% <71.42%> (-1.97%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| ... and [415 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...1f436ec](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `5.78%`.
> The diff coverage is `56.45%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 65.58% -5.79%
==========================================
Files 585 585
Lines 30987 31008 +21
Branches 3267 3272 +5
==========================================
- Hits 22116 20336 -1780
- Misses 8760 10491 +1731
- Partials 111 181 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.35% <48.78%> (-0.05%)` | :arrow_down: |
| #python | `69.97% <71.42%> (-1.62%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | `13.33% <0.00%> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `67.41% <0.00%> (-22.48%)` | :arrow_down: |
| [...tend/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24uanN4) | `50.00% <0.00%> (-26.32%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `68.93% <41.66%> (-12.72%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `50.27% <70.00%> (-11.56%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `73.75% <100.00%> (ø)` | |
| ... and [157 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...76f5371](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=h1) Report
> Merging [#9975](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/21fc0116d00a486d6dcbf661b56d628325e7c171&el=desc) will **decrease** coverage by `1.56%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9975 +/- ##
==========================================
- Coverage 71.37% 69.80% -1.57%
==========================================
Files 585 184 -401
Lines 30987 18097 -12890
Branches 3267 0 -3267
==========================================
- Hits 22116 12633 -9483
+ Misses 8760 5464 -3296
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.80% <71.42%> (-1.78%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.15% <ø> (-14.80%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <ø> (ø)` | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.24% <50.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.31% <73.68%> (-1.61%)` | :arrow_down: |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| ... and [407 more](https://codecov.io/gh/apache/incubator-superset/pull/9975/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=footer). Last update [21fc011...1f436ec](https://codecov.io/gh/apache/incubator-superset/pull/9975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9975: [WIP] feat: finalize Word Cloud move to new chart data endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9975:
URL: https://github.com/apache/incubator-superset/pull/9975#issuecomment-637982957
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org