You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/02 17:44:27 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #15513: [fix][ci] Fix tests memory leak due to mockito-inline
nicoloboschi opened a new pull request, #15513:
URL: https://github.com/apache/pulsar/pull/15513
### Motivation
I noticed an increased memory usage in long-running process which run the unit broker tests. After investigating I found out the introduction of mockito-inline is the culprit.
In the documentation is specified that it this behaviour is possible and [there's a way to fix it](https://javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/Mockito.html#47)
### Modifications
* Added the inline mocks cleanup between tests along with other mockito cleanups
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #15513: [fix][ci] Fix tests memory leak due to mockito-inline
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #15513:
URL: https://github.com/apache/pulsar/pull/15513#issuecomment-1128883820
>are the tests more flaky after this change or are there real failures?
I believe they are flaky as always. I addressed the `PersistentDispatcherFailoverConsumerTest` in https://github.com/apache/pulsar/pull/15638
let me re-run the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi merged pull request #15513: [fix][ci] Fix tests memory leak due to mockito-inline
Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #15513:
URL: https://github.com/apache/pulsar/pull/15513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #15513: [fix][ci] Fix tests memory leak due to mockito-inline
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #15513:
URL: https://github.com/apache/pulsar/pull/15513#issuecomment-1126112785
@nicoloboschi Are the tests more flaky after this change or are there real failures? I wonder if the classloading works correctly for Mockito if reflection isn't used in a TestNG listener?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #15513: [fix][ci] Fix tests memory leak due to mockito-inline
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #15513:
URL: https://github.com/apache/pulsar/pull/15513#issuecomment-1123890111
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #15513: [fix][ci] Fix tests memory leak due to mockito-inline
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #15513:
URL: https://github.com/apache/pulsar/pull/15513#issuecomment-1122546229
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #15513: [fix][ci] Fix tests memory leak due to mockito-inline
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #15513:
URL: https://github.com/apache/pulsar/pull/15513#issuecomment-1122112094
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #15513: [fix][ci] Fix tests memory leak due to mockito-inline
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #15513:
URL: https://github.com/apache/pulsar/pull/15513#issuecomment-1128884161
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #15513: [fix][ci] Fix tests memory leak due to mockito-inline
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #15513:
URL: https://github.com/apache/pulsar/pull/15513#issuecomment-1128997987
it is better to merge https://github.com/apache/pulsar/pull/15638 before this one. then rebase and re-run the checks to see everything is green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari closed pull request #15513: [fix][ci] Fix tests memory leak due to mockito-inline
Posted by GitBox <gi...@apache.org>.
lhotari closed pull request #15513: [fix][ci] Fix tests memory leak due to mockito-inline
URL: https://github.com/apache/pulsar/pull/15513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #15513: [fix][ci] Fix tests memory leak due to mockito-inline
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #15513:
URL: https://github.com/apache/pulsar/pull/15513#issuecomment-1145136025
This fix is important for stabilizing our CI. My assumption is that it would fix the strange issue #15689 where Mocks from another test are leaked into that test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #15513: [fix][ci] Fix tests memory leak due to mockito-inline
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #15513:
URL: https://github.com/apache/pulsar/pull/15513#issuecomment-1145187836
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #15513: [fix][ci] Fix tests memory leak due to mockito-inline
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #15513:
URL: https://github.com/apache/pulsar/pull/15513#issuecomment-1123674724
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org