You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:42:11 UTC

[GitHub] [incubator-tvm] wrongtest opened a new pull request #5751: Add compile_shared option to linux compile utility fn

wrongtest opened a new pull request #5751:
URL: https://github.com/apache/incubator-tvm/pull/5751


   Refer to https://discuss.tvm.ai/t/confusing-error-message-when-mod-export-library-with-non-standard-library-suffix/6911
   
   When we call export_library(filename) and use `_cc.create_shared()` as `fcompile` function, we may always expect to create shared library binary file. Thus the link flags may always take `-shared` under linux. With this PR we can export shared library without file name restriction.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen merged pull request #5751: [RUNTIME] Add compile_shared option to linux compile utility fn

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5751:
URL: https://github.com/apache/incubator-tvm/pull/5751


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] wrongtest commented on pull request #5751: [RUNTIME] Add compile_shared option to linux compile utility fn

Posted by GitBox <gi...@apache.org>.
wrongtest commented on pull request #5751:
URL: https://github.com/apache/incubator-tvm/pull/5751#issuecomment-643192908


   Can someone review this pr? cc @tqchen 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5751: [RUNTIME] Add compile_shared option to linux compile utility fn

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5751:
URL: https://github.com/apache/incubator-tvm/pull/5751#issuecomment-643332663


   Thansk @wrongtest !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] wrongtest commented on pull request #5751: [RUNTIME] Add compile_shared option to linux compile utility fn

Posted by GitBox <gi...@apache.org>.
wrongtest commented on pull request #5751:
URL: https://github.com/apache/incubator-tvm/pull/5751#issuecomment-642423655


   There are two python unittest case aims to create executable binary but finally run into `cc.create_shared()` code path. We add a new utility fn `cc.create_executable()` for such explicit purposes. 
   - tests/python/unittest/test_runtime_rpc.py::test_rpc_echo
   - tests/python/unittest/test_runtime_rpc.py::test_rpc_remote_module
   - tests/python/contrib/test_binutil.py


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org