You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by dkhwangbo <gi...@git.apache.org> on 2015/11/16 06:50:13 UTC
[GitHub] tajo pull request: TAJO-1979: Usage of some TajoShellCommand is om...
GitHub user dkhwangbo opened a pull request:
https://github.com/apache/tajo/pull/862
TAJO-1979: Usage of some TajoShellCommand is omitted
Write omitted usage of TajoShellCommand.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dkhwangbo/tajo TAJO-1979
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/862.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #862
----
commit 395ba2ea49e1c5ea3f971a2c5389adf711967274
Author: Dongkyu Hwangbo <hw...@gmail.com>
Date: 2015-11-16T05:48:05Z
initial commit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1979: Usage of some TajoShellCommand is om...
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on the pull request:
https://github.com/apache/tajo/pull/862#issuecomment-157240753
@blrunner Thanks for your review. I found another bug that ```getUsage()``` has no usage in whole TAJO, so I have no idea about making unit test cases. ```TajoShellCommand::printHelp()``` needs ```getUsage()``` but It's omitted. After resolve this issue in another ticket, I add unit test cases relate of this PR using shell command like ```TestTajoCli::testTimeZoneSessionVars1()```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1979: Usage of some TajoShellCommand is om...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/862#issuecomment-161533532
+1
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1979: Usage of some TajoShellCommand is om...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/862#issuecomment-159116854
I know you've finished the issue which is involved with this PR. Could you add an unit test case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1979: Usage of some TajoShellCommand is om...
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on the pull request:
https://github.com/apache/tajo/pull/862#issuecomment-159118760
@blrunner Oh, thanks for your remind. I'll add unit soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1979: Usage of some TajoShellCommand is om...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/862#issuecomment-156965804
If you add some unit test cases for this patch, it would be more better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1979: Usage of some TajoShellCommand is om...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/862
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1979: Usage of some TajoShellCommand is om...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on a diff in the pull request:
https://github.com/apache/tajo/pull/862#discussion_r44901940
--- Diff: tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ConnectDatabaseCommand.java ---
@@ -63,7 +63,7 @@ public void invoke(String[] cmd) throws Exception {
@Override
public String getUsage() {
- return "";
+ return "[database_name]";
--- End diff --
How about use ```DBNAME``` instead of ```database_name```? TSQL already uses ```DBNAME``` to print help descriptions with ```\help``` parameter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1979: Usage of some TajoShellCommand is om...
Posted by dkhwangbo <gi...@git.apache.org>.
Github user dkhwangbo commented on a diff in the pull request:
https://github.com/apache/tajo/pull/862#discussion_r45013717
--- Diff: tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/ConnectDatabaseCommand.java ---
@@ -63,7 +63,7 @@ public void invoke(String[] cmd) throws Exception {
@Override
public String getUsage() {
- return "";
+ return "[database_name]";
--- End diff --
I write ```database_name``` refer to ```DescTableCommand::getUsage()```. In ```DescTableCommand::getUsage()```, return ```[table_name]``` in spite of ```[TBNAME]``` with ```\help``` . You mean that editting other ```getUsage()``` is needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---