You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/09 10:44:25 UTC

[GitHub] [spark] uncleGen commented on a change in pull request #24323: [SPARK-27413][SS] keep the same epoch pace between driver and executor.

uncleGen commented on a change in pull request #24323: [SPARK-27413][SS] keep the same epoch pace between driver and executor.
URL: https://github.com/apache/spark/pull/24323#discussion_r273430603
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala
 ##########
 @@ -311,9 +311,8 @@ trait StreamTest extends QueryTest with SharedSQLContext with TimeLimits with Be
     def apply(): AssertOnQuery =
       Execute {
         case s: ContinuousExecution =>
-          val newEpoch = EpochCoordinatorRef.get(s.currentEpochCoordinatorId, SparkEnv.get)
+          EpochCoordinatorRef.get(s.currentEpochCoordinatorId, SparkEnv.get)
             .askSync[Long](IncrementAndGetEpoch)
-          s.awaitEpoch(newEpoch - 1)
 
 Review comment:
   This wait will block unit test in case of `longContinuousTrigger`  like 1 hour.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org