You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/08/30 00:55:31 UTC

[PR] fix(dlq): reject blank selected message IDs [rocketmq-dashboard]

yyqdbngt opened a new pull request, #2809:
URL: https://github.com/apache/rocketmq-dashboard/pull/2809

   ## Summary
   - validate every selected DLQ message ID instead of only validating the list size
   - reject empty and whitespace-only IDs before invoking the provider
   - add controller-level regression coverage
   
   ## Why
   A syntactically non-empty selection such as `["   "]` passed request validation and reached the resend provider with an unusable message identifier.
   
   ## Testing
   - `JAVA_HOME=/opt/homebrew/opt/openjdk@21 PATH=/opt/homebrew/opt/openjdk@21/bin:$PATH ./mvnw -f server/pom.xml -Dtest=DLQControllerTest test`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(dlq): reject blank selected message IDs [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2809:
URL: https://github.com/apache/rocketmq-dashboard/pull/2809#issuecomment-5477628206

   Merged into the #2656 consolidation batch (same author, backend sanitization fixes).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(dlq): reject blank selected message IDs [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2809: fix(dlq): reject blank selected message IDs
URL: https://github.com/apache/rocketmq-dashboard/pull/2809


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org