You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/20 07:50:16 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #128: Makefile don't change symtab_apps.c timestamp if no any change

xiaoxiang781216 opened a new pull request #128: Makefile don't change symtab_apps.c timestamp if no any change
URL: https://github.com/apache/incubator-nuttx-apps/pull/128
 
 
   Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
   Change-Id: I55576aec46bd057bc98cf2b6579d7ac96446ae27

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on issue #128: Makefile don't change symtab_apps.c timestamp if no any change

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #128: Makefile don't change symtab_apps.c timestamp if no any change
URL: https://github.com/apache/incubator-nuttx-apps/pull/128#issuecomment-602002218
 
 
   > @xiaoxiang781216 Let me confirm. In my understanding, this PR is not to fix a bug but to optimize total build time when a loadable application code is changed but symbols in symtab_apps.c are not changed. Is my understanding correct?
   
   Yes, its' just an optimization.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-apps] masayuki2009 merged pull request #128: Makefile don't change symtab_apps.c timestamp if no any change

Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #128: Makefile don't change symtab_apps.c timestamp if no any change
URL: https://github.com/apache/incubator-nuttx-apps/pull/128
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on issue #128: Makefile don't change symtab_apps.c timestamp if no any change

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #128: Makefile don't change symtab_apps.c timestamp if no any change
URL: https://github.com/apache/incubator-nuttx-apps/pull/128#issuecomment-602010163
 
 
   > Yes, its' just an optimization.
   
   @xiaoxiang781216 Thanks for the comment.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services