[GitHub] [ozone] symious commented on a diff in pull request #4128: HDDS-5686. Support transfer leadership

[GitBox <gi...@apache.org>]

symious commented on code in PR #4128:
URL: https://github.com/apache/ozone/pull/4128#discussion_r1067666218


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java:
##########
@@ -277,6 +277,7 @@ public static boolean isReadOnly(
       // Although indirectly the Ranger sync service task could invoke write
       // operation SetRangerServiceVersion.
     case GetKeyInfo:
+    case TransferLeadership:

Review Comment:
   If it's a write operation, the request would be sent to all 3 OMs, not just the leader one.
   Besides, I think the the request is also treated as a READ operation in ratis? https://github.com/apache/ratis/blob/master/ratis-common/src/main/java/org/apache/ratis/protocol/TransferLeadershipRequest.java#L25



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org