You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "dhruba borthakur (JIRA)" <ji...@apache.org> on 2008/09/05 07:55:44 UTC
[jira] Created: (HADOOP-4077) Access permissions for setting access
times and modification times for files
Access permissions for setting access times and modification times for files
----------------------------------------------------------------------------
Key: HADOOP-4077
URL: https://issues.apache.org/jira/browse/HADOOP-4077
Project: Hadoop Core
Issue Type: Bug
Components: dfs
Reporter: dhruba borthakur
Assignee: dhruba borthakur
HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4077) Access permissions for setting access
times and modification times for files
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-4077:
-------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks Nicholas and Konstantin for your review comments.
> Access permissions for setting access times and modification times for files
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4077
> URL: https://issues.apache.org/jira/browse/HADOOP-4077
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: accessTimes.patch
>
>
> HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4077) Access permissions for setting access
times and modification times for files
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-4077:
-------------------------------------
Status: Patch Available (was: Open)
> Access permissions for setting access times and modification times for files
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4077
> URL: https://issues.apache.org/jira/browse/HADOOP-4077
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: accessTimes.patch
>
>
> HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4077) Access permissions for setting
access times and modification times for files
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632797#action_12632797 ]
Hadoop QA commented on HADOOP-4077:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390507/accessTimes.patch
against trunk revision 697156.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3333/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3333/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3333/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3333/console
This message is automatically generated.
> Access permissions for setting access times and modification times for files
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4077
> URL: https://issues.apache.org/jira/browse/HADOOP-4077
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: accessTimes.patch
>
>
> HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4077) Access permissions for setting access
times and modification times for files
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-4077:
-------------------------------------
Priority: Blocker (was: Major)
> Access permissions for setting access times and modification times for files
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4077
> URL: https://issues.apache.org/jira/browse/HADOOP-4077
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Priority: Blocker
>
> HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4077) Access permissions for setting
access times and modification times for files
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628742#action_12628742 ]
dhruba borthakur commented on HADOOP-4077:
------------------------------------------
Hi Doug, the patch in H-1869 implements the policy of requiring read-permission to set the access time and requiring write permission to set modification time. This works in some use-cases. However, this is different from the POSIX standard.
I would like to get this resolved before shipping 0.19, hence marking it as a blocker.
> Access permissions for setting access times and modification times for files
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4077
> URL: https://issues.apache.org/jira/browse/HADOOP-4077
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
>
> HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4077) Access permissions for setting
access times and modification times for files
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633316#action_12633316 ]
Hudson commented on HADOOP-4077:
--------------------------------
Integrated in Hadoop-trunk #611 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/611/])
> Access permissions for setting access times and modification times for files
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4077
> URL: https://issues.apache.org/jira/browse/HADOOP-4077
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: accessTimes.patch
>
>
> HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4077) Access permissions for setting access
times and modification times for files
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-4077:
-------------------------------------
Affects Version/s: 0.19.0
Fix Version/s: 0.19.0
> Access permissions for setting access times and modification times for files
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4077
> URL: https://issues.apache.org/jira/browse/HADOOP-4077
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.0
>
>
> HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4077) Access permissions for setting access
times and modification times for files
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-4077:
-------------------------------------
Status: Open (was: Patch Available)
> Access permissions for setting access times and modification times for files
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4077
> URL: https://issues.apache.org/jira/browse/HADOOP-4077
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: accessTimes.patch
>
>
> HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4077) Access permissions for setting
access times and modification times for files
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632782#action_12632782 ]
Raghu Angadi commented on HADOOP-4077:
--------------------------------------
+1.
Minor : comment still says : {{'// The caller needs to have write access to set modification times'}}.
> Access permissions for setting access times and modification times for files
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4077
> URL: https://issues.apache.org/jira/browse/HADOOP-4077
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: accessTimes.patch
>
>
> HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4077) Access permissions for setting access
times and modification times for files
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-4077:
-------------------------------------
Status: Patch Available (was: Open)
> Access permissions for setting access times and modification times for files
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4077
> URL: https://issues.apache.org/jira/browse/HADOOP-4077
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: accessTimes.patch
>
>
> HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-4077) Access permissions for
setting access times and modification times for files
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632821#action_12632821 ]
dhruba edited comment on HADOOP-4077 at 9/19/08 2:04 PM:
-------------------------------------------------------------------
I just committed this. Thanks Nicholas and Raghu for your review comments.
was (Author: dhruba):
I just committed this. Thanks Nicholas and Konstantin for your review comments.
> Access permissions for setting access times and modification times for files
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4077
> URL: https://issues.apache.org/jira/browse/HADOOP-4077
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: accessTimes.patch
>
>
> HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4077) Access permissions for setting
access times and modification times for files
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628942#action_12628942 ]
dhruba borthakur commented on HADOOP-4077:
------------------------------------------
I propose that one can set any arbitrary access time or modification time if one has write permission to the file in question.
> Access permissions for setting access times and modification times for files
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4077
> URL: https://issues.apache.org/jira/browse/HADOOP-4077
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.0
>
>
> HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4077) Access permissions for setting
access times and modification times for files
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632801#action_12632801 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4077:
------------------------------------------------
This might belong to a different issue: if inode == null in FSNamesystem.setTimes(...), should we throw an exception? Otherwise, client cannot tell whether the operation is success or failed.
> Access permissions for setting access times and modification times for files
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4077
> URL: https://issues.apache.org/jira/browse/HADOOP-4077
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: accessTimes.patch
>
>
> HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4077) Access permissions for setting access
times and modification times for files
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-4077:
-------------------------------------
Attachment: accessTimes.patch
Write permission is required to set access times on files.
> Access permissions for setting access times and modification times for files
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4077
> URL: https://issues.apache.org/jira/browse/HADOOP-4077
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.19.0
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: accessTimes.patch
>
>
> HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4077) Access permissions for setting
access times and modification times for files
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628672#action_12628672 ]
Doug Cutting commented on HADOOP-4077:
--------------------------------------
> We need to decide what access checks to make before allowing a client to use this new API.
So perhaps the dependency should be inverted, HADOOP-1869 should depend on this rather than vice versa?
> Access permissions for setting access times and modification times for files
> ----------------------------------------------------------------------------
>
> Key: HADOOP-4077
> URL: https://issues.apache.org/jira/browse/HADOOP-4077
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
>
> HADOOP-1869 implements an API to set access and modification times for files. We need to decide what access checks to make before allowing a client to use this new API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.