[GitHub] [dubbo-go-pixiu] baerwang commented on a diff in pull request #436: feat:consistent hashing

[GitBox <gi...@apache.org>]

baerwang commented on code in PR #436:
URL: https://github.com/apache/dubbo-go-pixiu/pull/436#discussion_r889686695


##########
pkg/cluster/loadbalancer/hash/consistent_hash.go:
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package consistent
+
+import (
+	"math/rand"
+)
+
+import (
+	"github.com/dubbogo/gost/hash/consistent"
+)
+
+import (
+	"github.com/apache/dubbo-go-pixiu/pkg/cluster/loadbalancer"
+	"github.com/apache/dubbo-go-pixiu/pkg/model"
+)
+
+func init() {
+	loadbalancer.RegisterLoadBalancer(model.LoadBalanceConsistentHashing, ConsistentHashing{})
+}
+
+var clusterMap = map[string]*consistent.Consistent{}
+
+type ConsistentHashing struct{}
+
+func (ConsistentHashing) Handler(c *model.ClusterConfig) *model.Endpoint {
+	data, ok := clusterMap[c.Name]
+	if ok {
+
+		// todo random ?
+		hash, err := data.GetHash(uint32(rand.Int31n(1023)))
+		if err != nil {
+			return nil
+		}
+
+		for _, endpoint := range c.Endpoints {
+			if endpoint.Address.Address == hash {
+				return endpoint
+			}
+		}
+
+		return nil

Review Comment:
   不会的，服务端这边有判断这个是否为空，然后会告诉用户找不到节点的



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org