You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/07/08 20:28:05 UTC
[GitHub] [druid] jihoonson edited a comment on pull request #10144: Follow-up for RetryQueryRunner fix
jihoonson edited a comment on pull request #10144:
URL: https://github.com/apache/druid/pull/10144#issuecomment-655738971
```
33 F | L private static final Logger LOG = new Logger(ReportTimelineMissingSegmentQueryRunner.class);
34 F
45 F | L LOG.debug("Reporting a missing segment[%s] for query[%s]", descriptor, queryPlus.getQuery().getId());
------------------------------------------------------------------------------
Diff coverage statistics:
------------------------------------------------------------------------------
| lines | branches | functions | path
------------------------------------------------------------------------------
| 0% (0/2) | 100% (0/0) | 100% (3/3) | org/apache/druid/query/ReportTimelineMissingSegmentQueryRunner.java
------------------------------------------------------------------------------
Total diff coverage:
- lines: 0% (0/2)
- branches: 100% (0/0)
- functions: 100% (3/3)
ERROR: Insufficient line coverage of 0% (0/2). Required 50%.
```
@gianm @clintropolis thank you for the review. I fixed the spell check failure, and the test coverage check is just not happy about the logging I added. I'm going to merge this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org