You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/26 11:53:53 UTC
[GitHub] [airflow] blcksrx opened a new pull request #7544: [AIRFLOW-6922]
Support python3.8
blcksrx opened a new pull request #7544: [AIRFLOW-6922] Support python3.8
URL: https://github.com/apache/airflow/pull/7544
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] blcksrx commented on issue #7544: [AIRFLOW-6922] Support
python3.8
Posted by GitBox <gi...@apache.org>.
blcksrx commented on issue #7544: [AIRFLOW-6922] Support python3.8
URL: https://github.com/apache/airflow/pull/7544#issuecomment-596239763
> Have you seen how this relates to
> `cattrs==1.0` and
> `typing_extensions`
> ?
>
> I think there are some PRs open in this regard, so it is not really that simple to make the migration to 3.8
Yes, it's not simple it was just a try!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] blcksrx commented on issue #7544: [AIRFLOW-6922] Support
python3.8
Posted by GitBox <gi...@apache.org>.
blcksrx commented on issue #7544: [AIRFLOW-6922] Support python3.8
URL: https://github.com/apache/airflow/pull/7544#issuecomment-597065709
> Yes we want to support python 3.8 -- but we need to decide what part of the matrix we suppport -- the way this is done right now this will make the tests significantly longer, which is not good for developer productivity, nor for our Travis bill.
You are right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] malthe commented on issue #7544: [AIRFLOW-6922] Support
python3.8
Posted by GitBox <gi...@apache.org>.
malthe commented on issue #7544: [AIRFLOW-6922] Support python3.8
URL: https://github.com/apache/airflow/pull/7544#issuecomment-595234091
Seems to fail while building image:
```
WARNING: Error loading config file: /root/.docker/config.json: \
stat /root/.docker/config.json: permission denied
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #7544: [AIRFLOW-6922]
Support python3.8
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7544: [AIRFLOW-6922] Support python3.8
URL: https://github.com/apache/airflow/pull/7544#issuecomment-592321041
It seem that 3.8 `typing` have some different to 3.6 and 3.7, So maybe we could not just support it by this way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #7544: [AIRFLOW-6922] Support
python3.8
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #7544: [AIRFLOW-6922] Support python3.8
URL: https://github.com/apache/airflow/pull/7544#issuecomment-597060008
Yes we want to support python 3.8 -- but we need to decide what part of the matrix we suppport -- the way this is done right now this will make the tests significantly longer, which is not good for developer productivity, nor for our Travis bill.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] joseangel-sc commented on issue #7544: [AIRFLOW-6922]
Support python3.8
Posted by GitBox <gi...@apache.org>.
joseangel-sc commented on issue #7544: [AIRFLOW-6922] Support python3.8
URL: https://github.com/apache/airflow/pull/7544#issuecomment-595388181
Have you seen how this relates to
`cattrs==1.0` and
`typing_extensions`
?
I think there are some PRs open in this regard, so it is not really that simple to make the migration to 3.8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] blcksrx closed pull request #7544: [AIRFLOW-6922] Support
python3.8
Posted by GitBox <gi...@apache.org>.
blcksrx closed pull request #7544: [AIRFLOW-6922] Support python3.8
URL: https://github.com/apache/airflow/pull/7544
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services