[GitHub] [beam] ahmedabu98 commented on a diff in pull request #25472: Handle Timestamp fields with UTC in Storage writes

["ahmedabu98 (via GitHub)" <gi...@apache.org>]

ahmedabu98 commented on code in PR #25472:
URL: https://github.com/apache/beam/pull/25472#discussion_r1106416825


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java:
##########
@@ -746,6 +755,12 @@ private static void fieldDescriptorFromTableField(
               return ChronoUnit.MICROS.between(
                   Instant.EPOCH, Instant.ofEpochMilli(Long.parseLong((String) value)));
             } catch (NumberFormatException e2) {
+              if (((String) value).endsWith("UTC")) {

Review Comment:
   that was already the current implementation, will change to have one date time formatter to parse from.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org