[GitHub] [incubator-doris] xinyiZzz commented on a diff in pull request #10072: [fix] (mem tracker) Fix some memory leaks, inaccurate statistics, core dump, deadlock bugs

[GitBox <gi...@apache.org>]

xinyiZzz commented on code in PR #10072:
URL: https://github.com/apache/incubator-doris/pull/10072#discussion_r895200511


##########
be/src/runtime/mem_tracker.cpp:
##########
@@ -124,14 +124,17 @@ std::shared_ptr<MemTracker> MemTracker::create_tracker_impl(
     std::string reset_label;
     MemTracker* task_parent_tracker = reset_parent->parent_task_mem_tracker();
     if (task_parent_tracker) {
-        reset_label = fmt::format("{}:{}", label, split(task_parent_tracker->label(), ":")[1]);
+        reset_label = fmt::format("{}&{}", label, split(task_parent_tracker->label(), "&")[1]);

Review Comment:
   Because `:` has many meanings as a separator in task mem tracker label, and `&` is only used to split out `queryId` or `loadID` or `tabletID`.
   
   The latest code replaces `&` with `#`, which seems a little nicer :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org