You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/01 07:56:16 UTC
[GitHub] [arrow] tobim opened a new pull request #7315: ARROW-7605: [C++] Bundle jemalloc into static libarrow
tobim opened a new pull request #7315:
URL: https://github.com/apache/arrow/pull/7315
This is an alternative to #6220.
This changes the linking method to jemalloc from linking to `libjemalloc.a` to using the objects it is comprised of when linking `libarrow`. The advantage over #6220 is that the approach taken here does not require different methods of linking jemalloc for `libarrow.so` and `libarrow.a`.
Mimalloc would need a similar treatment before this can be merged, but I'm putting this out for comment before I develop it any further.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7315: ARROW-7605: [C++] Bundle jemalloc into static libarrow
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7315:
URL: https://github.com/apache/arrow/pull/7315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] tobim commented on pull request #7315: ARROW-7605: [C++] Bundle jemalloc into static libarrow
Posted by GitBox <gi...@apache.org>.
tobim commented on pull request #7315:
URL: https://github.com/apache/arrow/pull/7315#issuecomment-652292544
> CMake 3.9 is a bit problematic since we've tried to support CMake >= 3.2 and definitely >= 3.7
In that case the other approach should be pursued.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7315: ARROW-7605: [C++] Bundle jemalloc into static libarrow
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7315:
URL: https://github.com/apache/arrow/pull/7315#issuecomment-645038858
Will this approach work on Windows? This doesn't look like it's going to work for all our dependencies that might be built in bundled mode. I still think the static lib splicing with AR is the most viable solution. Do others have opinions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm edited a comment on pull request #7315: ARROW-7605: [C++] Bundle jemalloc into static libarrow
Posted by GitBox <gi...@apache.org>.
wesm edited a comment on pull request #7315:
URL: https://github.com/apache/arrow/pull/7315#issuecomment-652020060
We're running out of time to get this completed for the release, so if a working solution can be demonstrated to have been reached on all 3 platforms that works for both jemalloc (for Linux and macOS) and mimalloc (for Windows), then I will accept it. But there are single digits days remaining to complete this work now. CMake 3.9 is a bit problematic since we've tried to support CMake >= 3.2 and definitely >= 3.7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7315: ARROW-7605: [C++] Bundle jemalloc into static libarrow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7315:
URL: https://github.com/apache/arrow/pull/7315#issuecomment-636683207
https://issues.apache.org/jira/browse/ARROW-7605
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm edited a comment on pull request #7315: ARROW-7605: [C++] Bundle jemalloc into static libarrow
Posted by GitBox <gi...@apache.org>.
wesm edited a comment on pull request #7315:
URL: https://github.com/apache/arrow/pull/7315#issuecomment-645038858
Will this approach work on Windows? This doesn't look like it's going to work for all our dependencies that might be built in bundled mode. I still think the static lib splicing with `ar` (and equivalents on macOS and Windows) is the most viable solution. Do others have opinions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] tobim commented on pull request #7315: ARROW-7605: [C++] Bundle jemalloc into static libarrow
Posted by GitBox <gi...@apache.org>.
tobim commented on pull request #7315:
URL: https://github.com/apache/arrow/pull/7315#issuecomment-652001357
@wesm I still believe this approach is the sanest, but seeing that it requires CMake 3.9 I guess that makes it a non-starter?
I would not expect problems with this on windows, but that is not my turf, so don't take my word for it. Which other bundled dependencies were you thinking of?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7315: ARROW-7605: [C++] Bundle jemalloc into static libarrow
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7315:
URL: https://github.com/apache/arrow/pull/7315#issuecomment-652020060
We're running out of time to get this completed for the release, so if a working solution can be demonstrated to have been reached on all 3 platforms that works for both jemalloc (for Linux and macOS) and mimalloc (for Windows), then I will accept it. But there are single digits days remaining to complete this work now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7315: ARROW-7605: [C++] Bundle jemalloc into static libarrow
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7315:
URL: https://github.com/apache/arrow/pull/7315#issuecomment-650658746
I'm going to close this for now and attempt to pursue the static library splicing solution for 1.0.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org