You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/24 23:03:45 UTC
[GitHub] [arrow] markhildreth commented on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly
markhildreth commented on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-619273713
@andygrove I think there is going to be more to this than this PR. The "nightly-2019-11-14" string [can be found in a few places](https://github.com/apache/arrow/search?q=nightly-2019-11-14&unscoped_q=nightly-2019-11-14), including some of the build scripts (notice that the workflows run for this PR are still called "2019-11-14").
@nevi-me @paddyhoran The problem with this error seems to be that the change was only made in rust-toolchain. As a result, the GHA workflows will still build a Windows environment with a nightly-2019-11-14 toolchain. When cargo attempts to build, it will notice that the toolchain is out of date with the `rust-toolchain` file, and attempt to pull the new toolchain on-the-fly. However, it doesn't pull `rust fmt` when this occurs.
```
installed toolchains
--------------------
stable-x86_64-pc-windows-msvc
nightly-2019-11-14-x86_64-pc-windows-msvc
active toolchain
----------------
nightly-2019-11-14-x86_64-pc-windows-msvc (directory override for '\\?\D:\a\arrow\arrow')
rustc 1.41.0-nightly (ded5ee001 2019-11-13)
+ mkdir -p /d/a/arrow/arrow/build/rust
+ pushd /d/a/arrow/arrow/rust
/d/a/arrow/arrow/rust /d/a/arrow/arrow
+ RUSTFLAGS='-D warnings'
+ cargo build --all-targets
info: syncing channel updates for 'nightly-2020-04-22-x86_64-pc-windows-msvc'
info: latest update on 2020-04-22, rust version 1.44.0-nightly (45d050cde 2020-04-21)
info: downloading component 'cargo'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: installing component 'cargo'
info: installing component 'rust-std'
info: installing component 'rustc'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org