You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Sriharsha Chintalapani <ha...@hortonworks.com> on 2014/10/13 01:49:39 UTC
Review Request 26633: Patch for KAFKA-1305
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26633/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1305
https://issues.apache.org/jira/browse/KAFKA-1305
Repository: kafka
Description
-------
KAFKA-1305. Controller can hang on controlled shutdown with auto leader balance enabled.
Diffs
-----
core/src/main/scala/kafka/controller/ControllerChannelManager.scala ecbfa0f328ba6a652a758ab20cacef324a8b2fb8
core/src/main/scala/kafka/server/KafkaConfig.scala 90af698b01ec82b6168e02b6af41887ef164ad51
system_test/mirror_maker_testsuite/config/server.properties c6284122e3dfaa046a453511c17a19a536dc1035
system_test/offset_management_testsuite/config/server.properties 2b988f86052a7bb248e1c7752808cb0a336d0020
system_test/offset_management_testsuite/testcase_7002/config/kafka_server_1.properties 41ec6e49272f129ab11a08aec04faf444f1c4f26
system_test/offset_management_testsuite/testcase_7002/config/kafka_server_2.properties 727e23701d6c2eb08c7ddde198e042921ef058f8
system_test/offset_management_testsuite/testcase_7002/config/kafka_server_3.properties e6fbbe1e0532eb393a5b100c8b3c58be4c546ec0
system_test/offset_management_testsuite/testcase_7002/config/kafka_server_4.properties fee65bce63564a7403d311be2c27c34e17e835a7
system_test/replication_testsuite/config/server.properties 6becbab60e3943e56a77dc7872febb9764b2dca9
Diff: https://reviews.apache.org/r/26633/diff/
Testing
-------
Thanks,
Sriharsha Chintalapani
Re: Review Request 26633: Patch for KAFKA-1305
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26633/#review56427
-----------------------------------------------------------
Ship it!
core/src/main/scala/kafka/server/KafkaConfig.scala
<https://reviews.apache.org/r/26633/#comment96710>
this looks good now.
- Neha Narkhede
On Oct. 13, 2014, 2:30 p.m., Sriharsha Chintalapani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26633/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 2:30 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1305
> https://issues.apache.org/jira/browse/KAFKA-1305
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1305. Controller can hang on controlled shutdown with auto leader balance enabled.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/KafkaConfig.scala 90af698b01ec82b6168e02b6af41887ef164ad51
>
> Diff: https://reviews.apache.org/r/26633/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sriharsha Chintalapani
>
>
Re: Review Request 26633: Patch for KAFKA-1305
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26633/
-----------------------------------------------------------
(Updated Oct. 13, 2014, 2:30 p.m.)
Review request for kafka.
Bugs: KAFKA-1305
https://issues.apache.org/jira/browse/KAFKA-1305
Repository: kafka
Description
-------
KAFKA-1305. Controller can hang on controlled shutdown with auto leader balance enabled.
Diffs (updated)
-----
core/src/main/scala/kafka/server/KafkaConfig.scala 90af698b01ec82b6168e02b6af41887ef164ad51
Diff: https://reviews.apache.org/r/26633/diff/
Testing
-------
Thanks,
Sriharsha Chintalapani