You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2016/03/09 23:18:20 UTC

[Bug 59156] New: XMLAssertion : Drop it or at least drop jdom dependency

https://bz.apache.org/bugzilla/show_bug.cgi?id=59156

            Bug ID: 59156
           Summary: XMLAssertion : Drop it or at least drop jdom
                    dependency
           Product: JMeter
           Version: 2.13
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: p.mouawad@ubik-ingenierie.com

Hello,
This assertion only checks that response is well-formed XML by parsing the file
using JDom 1.X which is now deprecated.

I personally don't find it very useful and have never used it.
So I would tend to drop it.
If we decide to keep it, then at least we should drop jdom dependency by just
using a javax SAXParser instead of:
http://www.jdom.org/docs/apidocs.1.1/org/jdom/input/SAXBuilder.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59156] XMLAssertion : drop jdom dependency by using XMLReader

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59156

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|XMLAssertion : Drop it or   |XMLAssertion : drop jdom
                   |at least drop jdom          |dependency by using
                   |dependency                  |XMLReader

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59156] XMLAssertion : drop jdom dependency by using XMLReader

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59156

--- Comment #3 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sat Mar 12 20:18:49 2016
New Revision: 1734731

URL: http://svn.apache.org/viewvc?rev=1734731&view=rev
Log:
Bug 59156 - XMLAssertion : drop jdom dependency by using XMLReader
jdom is now a jar for docs
Bugzilla Id: 59156

Modified:
    jmeter/trunk/test/src/org/apache/jmeter/JMeterVersionTest.java

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59156] XMLAssertion : drop jdom dependency by using XMLReader

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59156

--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sat Mar 12 20:58:04 2016
New Revision: 1734736

URL: http://svn.apache.org/viewvc?rev=1734736&view=rev
Log:
Bug 59156 - XMLAssertion : drop jdom dependency by using XMLReader
Fix bug
Bugzilla Id: 59156

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/assertions/XMLAssertion.java

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59156] XMLAssertion : Drop it or at least drop jdom dependency

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59156

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om

--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Created attachment 33654
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33654&action=edit
Patch dropping JDOM

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 59156] XMLAssertion : drop jdom dependency by using XMLReader

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=59156

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sat Mar 12 14:25:49 2016
New Revision: 1734706

URL: http://svn.apache.org/viewvc?rev=1734706&view=rev
Log:
Bug 59156 - XMLAssertion : drop jdom dependency by using XMLReader
Move code to standard Java XML API
Fix Tests to remove dependencies on jdom
Move jdom download to lib/doc as it is needed for printable documentation
generation (Anakia)
Remove jdom from Maven dependencies and also remove velocity version property
by the way as it is not needed (commented)
Move jdom reference in build.properties in the doc block
Bugzilla Id: 59156

Modified:
    jmeter/trunk/build.properties
    jmeter/trunk/build.xml
    jmeter/trunk/eclipse.classpath
    jmeter/trunk/lib/   (props changed)
    jmeter/trunk/lib/aareadme.txt
    jmeter/trunk/lib/doc/   (props changed)
    jmeter/trunk/res/maven/ApacheJMeter_parent.pom
    jmeter/trunk/src/components/org/apache/jmeter/assertions/XMLAssertion.java
   
jmeter/trunk/test/src/org/apache/jmeter/functions/ComponentReferenceFunctionTest.java
    jmeter/trunk/test/src/org/apache/jmeter/junit/JMeterTest.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.