[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24189: [SPARK-27253][SQL]SparkSession clone discards SQLConf overrides in favor of SparkConf defaults

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on a change in pull request #24189: [SPARK-27253][SQL]SparkSession clone discards SQLConf overrides in favor of SparkConf defaults
URL: https://github.com/apache/spark/pull/24189#discussion_r268577175
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/SessionStateSuite.scala
 ##########
 @@ -219,4 +222,23 @@ class SessionStateSuite extends SparkFunSuite {
     val forkedSession = activeSession.cloneSession()
     assert(activeSession.sharedState eq forkedSession.sharedState)
   }
+
+  test("SPARK-27253 forked new session should inherit Default options") {
+    val key = "default-config"
+    try {
+      //  override default conf
+      activeSession.conf.set(key, "active")
+
+      // inheritance
+      val forkedSession = activeSession.cloneSession()
+      assert(forkedSession ne activeSession)
+      assert(forkedSession.conf ne activeSession.conf)
+
+      // independence
 
 Review comment:
   Nit: This is not testing the independence.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org