You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/06/22 23:34:57 UTC
[GitHub] mkiiskila commented on a change in pull request #90: Fixes in NMP
encoding code
mkiiskila commented on a change in pull request #90: Fixes in NMP encoding code
URL: https://github.com/apache/mynewt-newtmgr/pull/90#discussion_r197591132
##########
File path: nmxact/nmp/echo.go
##########
@@ -22,14 +22,14 @@ package nmp
import ()
type EchoReq struct {
- NmpBase
+ NmpBase `codec:"-"`
Payload string `codec:"d"`
}
type EchoRsp struct {
NmpBase
Payload string `codec:"r"`
- Rc int `codec:"rc" codec:",omitempty"`
+ Rc int `codec:"rc"`
Review comment:
So you tested this with OIC option, and it works? I don't remember this being always sent with oicmgr. But I could be mistaken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services