[jira] [Commented] (FILEUPLOAD-256) FileCleanerCleanup throws NPE on shut-down

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FILEUPLOAD-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14174585#comment-14174585 ] 

ASF GitHub Bot commented on FILEUPLOAD-256:
-------------------------------------------

GitHub user jamessawle opened a pull request:

    https://github.com/apache/commons-fileupload/pull/4

    FILEUPLOAD-256 Added null pointer handling

    Added null pointer handling to stop NPEs being thrown.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jamessawle/commons-fileupload FILEUPLOAD-256

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-fileupload/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
    
----
commit b9cda9e63f36fa91648deebf881f999b484dac80
Author: James Sawle <ja...@hotmail.com>
Date:   2014-10-17T01:16:43Z

    FILEUPLOAD-256 Added null pointer handling around the FileCleaningTracker termination to ensure NullPointerExceptions are no longer thrown.

----


> FileCleanerCleanup throws NPE on shut-down
> ------------------------------------------
>
>                 Key: FILEUPLOAD-256
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-256
>             Project: Commons FileUpload
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Til Schneider
>            Priority: Minor
>
> FileCleanerCleanup throws NPE on shut-down if there was no file uploaded.
> Here's the stack trace:
> {code}
> java.lang.NullPointerException
> 	at org.apache.commons.fileupload.servlet.FileCleanerCleanup.contextDestroyed(FileCleanerCleanup.java:87)
> 	at org.mortbay.jetty.handler.ContextHandler.doStop(ContextHandler.java:600)
> 	...
> {code}
> A simple check, whether there is a FileCleaningTracker for that ServletContext should fix this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)