You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/14 13:16:54 UTC
[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1049: feat: support patch in route module in order to support publish/offline
liuxiran opened a new pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] New feature provided
- Related issues
BE of https://github.com/apache/apisix-dashboard/issues/837
support for https://github.com/apache/apisix-dashboard/pull/991
borrow from https://github.com/apache/apisix-dashboard/pull/1005
depends on APISIX release with https://github.com/apache/apisix/issues/2737 and sync `https://github.com/apache/apisix-dashboard/blob/master/api/conf/schema.json`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#discussion_r543377491
##########
File path: api/test/e2e/route_test.go
##########
@@ -224,6 +224,48 @@ func TestRoute_Update_Routes_With_Hosts(t *testing.T) {
}
}
+func TestRoute_Patch(t *testing.T) {
+ tests := []HttpTestCase{
+ {
+ caseDesc: "route patch",
Review comment:
we should always create the related resource first.
eg: the `route` resource
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
nic-chen closed pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-745312361
It seems that the E2E test cases is unstable, @nic-chen please take a look:
```
--- FAIL: TestRoute_Create_Service (0.93s)
Error: printer.go:54: GET http://127.0.0.1:9080/server_port
Error: printer.go:54: PUT http://127.0.0.1:9000/apisix/admin/services/200
Error: printer.go:54: PUT http://127.0.0.1:9000/apisix/admin/routes/r1
route_service_upstream_test.go:190:
Error Trace: route_service_upstream_test.go:190
Error: Not equal:
expected: 6
actual : 7
Test: TestRoute_Create_Service
route_service_upstream_test.go:192:
Error Trace: route_service_upstream_test.go:192
Error: Not equal:
expected: 6
actual : 5
Test: TestRoute_Create_Service
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#discussion_r544810323
##########
File path: api/test/e2e/route_test.go
##########
@@ -224,6 +224,48 @@ func TestRoute_Update_Routes_With_Hosts(t *testing.T) {
}
}
+func TestRoute_Patch(t *testing.T) {
+ tests := []HttpTestCase{
+ {
+ caseDesc: "route patch",
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-744468932
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=h1) Report
> Merging [#1049](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=desc) (8ce330b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/7c5fe957f47c402fd2544f46fd373ee6ea691f91?el=desc) (7c5fe95) will **decrease** coverage by `0.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1049 +/- ##
==========================================
- Coverage 40.13% 39.66% -0.48%
==========================================
Files 26 26
Lines 1572 1591 +19
==========================================
Hits 631 631
- Misses 850 869 +19
Partials 91 91
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1049/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `42.30% <0.00%> (-4.26%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=footer). Last update [7c5fe95...8ce330b](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-748733566
this PR should be closed now. feel free to reopen it if you need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#discussion_r545614856
##########
File path: api/internal/core/entity/entity.go
##########
@@ -83,6 +83,7 @@ type Route struct {
ServiceProtocol string `json:"service_protocol,omitempty"`
Labels map[string]string `json:"labels,omitempty"`
EnableWebsocket bool `json:"enable_websocket,omitempty"`
+ Status uint8 `json:"status"`
Review comment:
@liuxiran @nic-chen
I guess this line need using a pointer to `Status` type, and should be changed to
```suggestion
Status *Status `json:"status"`
```
With `uint8`, we can not distinguish whether the `status` field is unset or set to `0`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-748561552
this pr has beening splited into two prs, and will be closed all the separated prs merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-745707428
> It seems that the E2E test cases is unstable, @nic-chen please take a look:
>
> ```
> --- FAIL: TestRoute_Create_Service (0.93s)
> Error: printer.go:54: GET http://127.0.0.1:9080/server_port
> Error: printer.go:54: PUT http://127.0.0.1:9000/apisix/admin/services/200
> Error: printer.go:54: PUT http://127.0.0.1:9000/apisix/admin/routes/r1
> route_service_upstream_test.go:190:
> Error Trace: route_service_upstream_test.go:190
> Error: Not equal:
> expected: 6
> actual : 7
> Test: TestRoute_Create_Service
> route_service_upstream_test.go:192:
> Error Trace: route_service_upstream_test.go:192
> Error: Not equal:
> expected: 6
> actual : 5
> Test: TestRoute_Create_Service
> ```
en, I have been working on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#discussion_r545634219
##########
File path: api/internal/core/entity/entity.go
##########
@@ -83,6 +83,7 @@ type Route struct {
ServiceProtocol string `json:"service_protocol,omitempty"`
Labels map[string]string `json:"labels,omitempty"`
EnableWebsocket bool `json:"enable_websocket,omitempty"`
+ Status uint8 `json:"status"`
Review comment:
sure, we can optimize this place. but they are not in the same bag and cannot be used directly in this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-744468932
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=h1) Report
> Merging [#1049](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=desc) (80692e0) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/7c5fe957f47c402fd2544f46fd373ee6ea691f91?el=desc) (7c5fe95) will **decrease** coverage by `0.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1049 +/- ##
==========================================
- Coverage 40.13% 39.66% -0.48%
==========================================
Files 26 26
Lines 1572 1591 +19
==========================================
Hits 631 631
- Misses 850 869 +19
Partials 91 91
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1049/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (ø)` | |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1049/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `42.30% <0.00%> (-4.26%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=footer). Last update [7c5fe95...80692e0](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#discussion_r545939271
##########
File path: api/internal/core/entity/entity.go
##########
@@ -83,6 +83,7 @@ type Route struct {
ServiceProtocol string `json:"service_protocol,omitempty"`
Labels map[string]string `json:"labels,omitempty"`
EnableWebsocket bool `json:"enable_websocket,omitempty"`
+ Status uint8 `json:"status"`
Review comment:
@imjoey It's because we process the raw request body and set default value when there is no `status`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-748408749
How about using the codes from apisix's master branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-747911973
Thanks for @nic-chen 's help, all test cases passed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-744468932
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=h1) Report
> Merging [#1049](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=desc) (499edf7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/7c5fe957f47c402fd2544f46fd373ee6ea691f91?el=desc) (7c5fe95) will **decrease** coverage by `0.47%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1049 +/- ##
==========================================
- Coverage 40.13% 39.66% -0.48%
==========================================
Files 26 26
Lines 1572 1591 +19
==========================================
Hits 631 631
- Misses 850 869 +19
Partials 91 91
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1049/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `42.30% <0.00%> (-4.26%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=footer). Last update [7c5fe95...499edf7](https://codecov.io/gh/apache/apisix-dashboard/pull/1049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#discussion_r546146569
##########
File path: api/internal/core/entity/entity.go
##########
@@ -83,6 +83,7 @@ type Route struct {
ServiceProtocol string `json:"service_protocol,omitempty"`
Labels map[string]string `json:"labels,omitempty"`
EnableWebsocket bool `json:"enable_websocket,omitempty"`
+ Status uint8 `json:"status"`
Review comment:
@nic-chen Got it and it's ok for me. Thanks for the explanation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#discussion_r545641794
##########
File path: api/internal/core/entity/entity.go
##########
@@ -83,6 +83,7 @@ type Route struct {
ServiceProtocol string `json:"service_protocol,omitempty"`
Labels map[string]string `json:"labels,omitempty"`
EnableWebsocket bool `json:"enable_websocket,omitempty"`
+ Status uint8 `json:"status"`
Review comment:
> sure, we can optimize this place. but they are not in the same bag and cannot be used directly in this way.
@nic-chen thanks for getting back to me. Shall we also need to use `*uint8` here instead of `uint8`? While honestly, the passed CI makes me rather confused, am I missing anything that could explicitly tell us the `status` param is **unset** or **set to 0**? This would bring great impact on creating a Route. Any feedback is much appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-748409143
> How about using the codes from apisix's master branch?
sure，we don't need to wait now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#discussion_r545641794
##########
File path: api/internal/core/entity/entity.go
##########
@@ -83,6 +83,7 @@ type Route struct {
ServiceProtocol string `json:"service_protocol,omitempty"`
Labels map[string]string `json:"labels,omitempty"`
EnableWebsocket bool `json:"enable_websocket,omitempty"`
+ Status uint8 `json:"status"`
Review comment:
> sure, we can optimize this place. but they are not in the same bag and cannot be used directly in this way.
@nic-chen thanks for getting back to me. Shall we also need to use `*uint8` here instead of `uint8`? While honestly, the passed CI makes me rather confused, am I missing anything that could explicitly tell us the `status` param is **unset** or **set to 0**? This would be an important impact for creating a Route. Any feedback is much appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
imjoey commented on a change in pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#discussion_r545641794
##########
File path: api/internal/core/entity/entity.go
##########
@@ -83,6 +83,7 @@ type Route struct {
ServiceProtocol string `json:"service_protocol,omitempty"`
Labels map[string]string `json:"labels,omitempty"`
EnableWebsocket bool `json:"enable_websocket,omitempty"`
+ Status uint8 `json:"status"`
Review comment:
> sure, we can optimize this place. but they are not in the same bag and cannot be used directly in this way.
@nic-chen thanks for getting back to me. Shall we also need to use `*uint8` here instead of `uint8`? While honestly, the passed CI makes me rather confused, am I missing anything that could explicitly tell us the `status` param is **unset** or **set to 0** ? Any feedback is much appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-747300236
CI failed @liuxiran
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1049: feat: support patch in route module in order to support publish/offline
Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on pull request #1049:
URL: https://github.com/apache/apisix-dashboard/pull/1049#issuecomment-748561552
this pr has beening splited into two prs, and will be closed after all the separated prs merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org