[GitHub] spark issue #15435: [SPARK-17139][ML] Add model summary for MultinomialLogis...

[sethah <gi...@git.apache.org>]

Github user sethah commented on the issue:

    https://github.com/apache/spark/pull/15435
  
    I still don't know what the plan _was_ for the downcasting issue, and it doesn't seem to me like there's really a good solution. `evaluate` returns a `LogisticRegressionSummary` so, we have to downcast that in the binary case regardless. We still have the issue of downcasting in the multiclass case if we ever have methods defined outside of the `LogisticRegressionSummary` trait.
    
    As far as the inheritance goes, I think a binary summary can do anything that a multiclass summary can do, so I think it's good to have `BinaryLogisticRegressionSummary extends MulticlassLogisticRegressionSummary`. 
    
    @jkbradley Is there any clarification you can provide?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org