[GitHub] [arrow] zinking commented on a diff in pull request #35570: GH-34252: [Java] Support ScannerBuilder::Project or ScannerBuilder::Filter as a Substrait proto extended expression

["zinking (via GitHub)" <gi...@apache.org>]

zinking commented on code in PR #35570:
URL: https://github.com/apache/arrow/pull/35570#discussion_r1278744780


##########
java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ScanOptions.java:
##########
@@ -25,8 +26,9 @@
  * Options used during scanning.
  */
 public class ScanOptions {
-  private final Optional<String[]> columns;
+  private final Optional<String[]> columnsSubset;
   private final long batchSize;
+  private Optional<ByteBuffer> columnsProduceOrFilter;

Review Comment:
   I'd suggest we still expose a simple unbound string in the interface, but leaving the construction (ser/deser) process in the dataset jar itself.
   
   I mean it's good to use subtrait as underlying implementation, but maybe we should just keep the interfaces simple.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org