You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/27 05:39:53 UTC

[GitHub] [airflow] mik-laj opened a new pull request #7565: [AIRFLOW-6941] Add queries ccount test for create_dagrun

mik-laj opened a new pull request #7565: [AIRFLOW-6941] Add queries ccount test for create_dagrun
URL: https://github.com/apache/airflow/pull/7565
 
 
   This test prevents regression for https://github.com/apache/airflow/pull/7510
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [X] Description above provides context of the change
   - [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [X] Unit tests coverage for changes (not needed for documentation changes)
   - [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [X] Relevant documentation is updated including usage instructions.
   - [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] feluelle commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun

Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun
URL: https://github.com/apache/airflow/pull/7565#discussion_r385633108
 
 

 ##########
 File path: tests/models/test_dag.py
 ##########
 @@ -1341,3 +1344,26 @@ class DAGsubclass(DAG):
         self.assertEqual(hash(dag_eq), hash(dag))
         self.assertNotEqual(hash(dag_diff_name), hash(dag))
         self.assertNotEqual(hash(dag_subclass), hash(dag))
+
+
+class TestPerformance(unittest.TestCase):
 
 Review comment:
   Sounds good to me. 👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun
URL: https://github.com/apache/airflow/pull/7565#discussion_r385176259
 
 

 ##########
 File path: tests/models/test_dag.py
 ##########
 @@ -1341,3 +1344,26 @@ class DAGsubclass(DAG):
         self.assertEqual(hash(dag_eq), hash(dag))
         self.assertNotEqual(hash(dag_diff_name), hash(dag))
         self.assertNotEqual(hash(dag_subclass), hash(dag))
+
+
+class TestPerformance(unittest.TestCase):
 
 Review comment:
   Work on other performance tests will start soon and then we should plan a solution on how we will mark the tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj merged pull request #7565: [AIRFLOW-6941] Add queries count test for create_dagrun

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7565: [AIRFLOW-6941] Add queries count test for create_dagrun
URL: https://github.com/apache/airflow/pull/7565
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun
URL: https://github.com/apache/airflow/pull/7565#discussion_r385172573
 
 

 ##########
 File path: tests/models/test_dag.py
 ##########
 @@ -1341,3 +1344,26 @@ class DAGsubclass(DAG):
         self.assertEqual(hash(dag_eq), hash(dag))
         self.assertNotEqual(hash(dag_diff_name), hash(dag))
         self.assertNotEqual(hash(dag_subclass), hash(dag))
+
+
+class TestPerformance(unittest.TestCase):
 
 Review comment:
   I don't think that's needed. These are very simple and small tests. In the future, when we introduce integration tests and tests for components, not just functions, we can do it. For me, this is a unit test, although it has slightly different assertions. Performance tests are tests that have metrics that can change in the environment. These tests do not change in the environment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun

Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun
URL: https://github.com/apache/airflow/pull/7565#discussion_r385154503
 
 

 ##########
 File path: tests/models/test_dag.py
 ##########
 @@ -1341,3 +1344,26 @@ class DAGsubclass(DAG):
         self.assertEqual(hash(dag_eq), hash(dag))
         self.assertNotEqual(hash(dag_diff_name), hash(dag))
         self.assertNotEqual(hash(dag_subclass), hash(dag))
+
+
+class TestPerformance(unittest.TestCase):
 
 Review comment:
   I would like to suggest to add new marker `performance`. Then we don't have to run this test multiple times. What do you think @mik-laj ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun

Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun
URL: https://github.com/apache/airflow/pull/7565#discussion_r385154503
 
 

 ##########
 File path: tests/models/test_dag.py
 ##########
 @@ -1341,3 +1344,26 @@ class DAGsubclass(DAG):
         self.assertEqual(hash(dag_eq), hash(dag))
         self.assertNotEqual(hash(dag_diff_name), hash(dag))
         self.assertNotEqual(hash(dag_subclass), hash(dag))
+
+
+class TestPerformance(unittest.TestCase):
 
 Review comment:
   I would like to suggest to add new marker `performance`. Then we don't have to run this test multiple times. What do you think @mik-laj ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add queries count test for create_dagrun
URL: https://github.com/apache/airflow/pull/7565#discussion_r385170832
 
 

 ##########
 File path: tests/models/test_dag.py
 ##########
 @@ -1341,3 +1344,26 @@ class DAGsubclass(DAG):
         self.assertEqual(hash(dag_eq), hash(dag))
         self.assertNotEqual(hash(dag_diff_name), hash(dag))
         self.assertNotEqual(hash(dag_subclass), hash(dag))
+
+
+class TestPerformance(unittest.TestCase):
 
 Review comment:
   I don't think that's needed. These are very simple and small tests. In the future, when we introduce integration tests and tests for components, not just functions, we can do it. For me, this is a unit test, although it has slightly different assertions. Performance tests are tests that have metrics that can change in the environment. These tests do not change in the environment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services