You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/22 13:48:00 UTC

[GitHub] [arrow-datafusion] Ted-Jiang commented on pull request #3903: Factorize common AND factors out of OR predicates to support filterPu…

Ted-Jiang commented on PR #3903:
URL: https://github.com/apache/arrow-datafusion/pull/3903#issuecomment-1287798493

   @alamb  Sorry for the late respond.
   >I feel like this code is a little confusing -- it isn't really doing a rewrite the same way other ExprRewriters do. Instead it is doing an analysis in one pass through (via pre_visit) and then replacing it in one go
   
   Yes😂, i think it because not mutate in the same place, this rewrite build an expr tress in another shape. I try to add `split_binary` to avoid some clone calls.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org