You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rednaxelafx <gi...@git.apache.org> on 2018/01/04 21:47:53 UTC
[GitHub] spark pull request #20158: Fix typo in comments in PySpark's udf() definitio...
GitHub user rednaxelafx opened a pull request:
https://github.com/apache/spark/pull/20158
Fix typo in comments in PySpark's udf() definition
## What changes were proposed in this pull request?
Just a simple typo fix from `curcuiting` to `circuiting`.
## How was this patch tested?
N/A. This patch does not change any code behavior.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rednaxelafx/apache-spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20158.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20158
----
commit 1d42d8697ca029c47acb4b44bd463e4a4142874c
Author: Kris Mok <re...@...>
Date: 2018-01-04T21:46:09Z
Fix typo in comments in PySpark's udf() definition
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20158
OK. Have a look for more typos while you're at it. We try to avoid whole PRs just to fix each one.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20158
You can just combine small-scale fixes to the surrounding code in the main PR then. I think that's fine.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20158
@rednaxelafx, can you fix the one in `pandas_udf` too? I'll just merge this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20158
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85700/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20158: [PySpark] Fix typo in comments in PySpark's udf()...
Posted by rednaxelafx <gi...@git.apache.org>.
Github user rednaxelafx closed the pull request at:
https://github.com/apache/spark/pull/20158
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...
Posted by rednaxelafx <gi...@git.apache.org>.
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20158
@srowen Thanks for your review! I'll have a look at other typos and update this PR later.
I was actually working on code around this place and thought I'd split out the typo fix to make it cleaner to review. Yes I totally agree it's a good idea to clean up more than one typo in a single PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/20158
Ping @rednaxelafx
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20158
let's get them fixed for 2.3?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20158
**[Test build #85700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85700/testReport)** for PR 20158 at commit [`1d42d86`](https://github.com/apache/spark/commit/1d42d8697ca029c47acb4b44bd463e4a4142874c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...
Posted by rednaxelafx <gi...@git.apache.org>.
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/20158
@HyukjinKwon cool! Thanks a lot for including it! Closing this one now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20158
@rednaxelafx, I was fixing some codes around UDF. I included the current typo in https://github.com/apache/spark/pull/20288. I think you could close this one.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20158
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20158
**[Test build #85700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85700/testReport)** for PR 20158 at commit [`1d42d86`](https://github.com/apache/spark/commit/1d42d8697ca029c47acb4b44bd463e4a4142874c).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20158: [PySpark] Fix typo in comments in PySpark's udf() defini...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20158
There's a same typo in `pandas_udf` too BTW.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org