You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sean Hsuan-Yi Chu <hs...@usc.edu> on 2015/04/03 18:40:43 UTC
Review Request 32799: DRILL-2596: CTAS plan should be shown in the
Web UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32799/
-----------------------------------------------------------
Review request for drill, Aman Sinha and Jason Altekruse.
Bugs: DRILL-2596
https://issues.apache.org/jira/browse/DRILL-2596
Repository: drill-git
Description
-------
Let the plan for CTAS queries be saved and shown in WebUI
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java 710418b
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java 111222e
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillSqlCall.java a6bd8b7
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateTable.java 5e3c215
Diff: https://reviews.apache.org/r/32799/diff/
Testing
-------
QA, unit tests
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 32799: DRILL-2596: CTAS plan should be shown in
the Web UI
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
> On April 3, 2015, 5:56 p.m., Aman Sinha wrote:
> > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java, line 137
> > <https://reviews.apache.org/r/32799/diff/1/?file=914237#file914237line137>
> >
> > Is it necessary to create a separate getSqlHandler method ? I think you could modify the existing DrillSqlCall.getSqlHandler() to accept a textPlan...the advantage of doing that would be that it would work even for other CREATE statements such as CREATE VIEW etc, in addition to CREATE TABLE.
For this one, we probably have to keep getSqlHandler(config) because lots of subclasses override this method; Any change on it could propagate a lot then.
- Sean Hsuan-Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32799/#review78810
-----------------------------------------------------------
On April 3, 2015, 8:07 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32799/
> -----------------------------------------------------------
>
> (Updated April 3, 2015, 8:07 p.m.)
>
>
> Review request for drill, Aman Sinha and Jason Altekruse.
>
>
> Bugs: DRILL-2596
> https://issues.apache.org/jira/browse/DRILL-2596
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Let the plan for CTAS queries be saved and shown in WebUI
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java 710418b
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java 111222e
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillSqlCall.java a6bd8b7
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateTable.java 5e3c215
>
> Diff: https://reviews.apache.org/r/32799/diff/
>
>
> Testing
> -------
>
> QA, unit tests
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 32799: DRILL-2596: CTAS plan should be shown in
the Web UI
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32799/#review78810
-----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
<https://reviews.apache.org/r/32799/#comment127843>
Is it necessary to create a separate getSqlHandler method ? I think you could modify the existing DrillSqlCall.getSqlHandler() to accept a textPlan...the advantage of doing that would be that it would work even for other CREATE statements such as CREATE VIEW etc, in addition to CREATE TABLE.
- Aman Sinha
On April 3, 2015, 4:40 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32799/
> -----------------------------------------------------------
>
> (Updated April 3, 2015, 4:40 p.m.)
>
>
> Review request for drill, Aman Sinha and Jason Altekruse.
>
>
> Bugs: DRILL-2596
> https://issues.apache.org/jira/browse/DRILL-2596
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Let the plan for CTAS queries be saved and shown in WebUI
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java 710418b
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java 111222e
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillSqlCall.java a6bd8b7
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateTable.java 5e3c215
>
> Diff: https://reviews.apache.org/r/32799/diff/
>
>
> Testing
> -------
>
> QA, unit tests
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 32799: DRILL-2596: CTAS plan should be shown in
the Web UI
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32799/#review78868
-----------------------------------------------------------
Ship it!
Ship It!
- Aman Sinha
On April 3, 2015, 8:07 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32799/
> -----------------------------------------------------------
>
> (Updated April 3, 2015, 8:07 p.m.)
>
>
> Review request for drill, Aman Sinha and Jason Altekruse.
>
>
> Bugs: DRILL-2596
> https://issues.apache.org/jira/browse/DRILL-2596
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Let the plan for CTAS queries be saved and shown in WebUI
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java 710418b
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java 111222e
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillSqlCall.java a6bd8b7
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateTable.java 5e3c215
>
> Diff: https://reviews.apache.org/r/32799/diff/
>
>
> Testing
> -------
>
> QA, unit tests
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 32799: DRILL-2596: CTAS plan should be shown in
the Web UI
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32799/
-----------------------------------------------------------
(Updated April 3, 2015, 8:07 p.m.)
Review request for drill, Aman Sinha and Jason Altekruse.
Bugs: DRILL-2596
https://issues.apache.org/jira/browse/DRILL-2596
Repository: drill-git
Description
-------
Let the plan for CTAS queries be saved and shown in WebUI
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java 710418b
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/CreateTableHandler.java 111222e
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillSqlCall.java a6bd8b7
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/SqlCreateTable.java 5e3c215
Diff: https://reviews.apache.org/r/32799/diff/
Testing
-------
QA, unit tests
Thanks,
Sean Hsuan-Yi Chu